This repository has been archived by the owner. It is now read-only.
Permalink
Switch branches/tags
Commits on Oct 20, 2014
  1. path: resolve normalize drive letter to lower case

    dead-horse authored and orangemocha committed Sep 17, 2014
    make path.resolve work the same as path.normalize
Commits on Oct 10, 2014
  1. build: vcbuild fix "The input line is too long."

    orangemocha committed Oct 10, 2014
    vcbuild.bat is calling vcvars.bat, which doesn't detect if the environment
    has already been set. This causes repeated entries to be added to the PATH,
    which after a few invocations will lead to an error:
    The input line is too long.
Commits on Oct 9, 2014
  1. streams: make setDefaultEncoding() throw

    mscdex authored and trevnorris committed Oct 9, 2014
    PR-URL: #8529
    Fixes: f04f3a0 "streams: set default encoding for writable streams"
    [trev.norris@gmail.com: update tests to check if throws]
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
  2. doc: correct createSecureContext

    cynron authored and trevnorris committed Oct 9, 2014
    Remove incorrect stablity indication of tls.createSecureContext, and
    format stablity indication of crypto.createCredentials.
    
    Fixes: e50749 "doc: document `tls.createSecureContext`"
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
  3. test: fix test-child-process-spawn-typeerror

    orangemocha authored and trevnorris committed Oct 8, 2014
    You cannot spawn 'dir' on Windows because it's not an executable.  Also,
    some people might have 'ls' on their path on Windows, so I changed
    invalidCmd to something that's highly unlikely to exist.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Commits on Oct 8, 2014
  1. doc: fix wording and punctuation in modules

    stiliyan authored and trevnorris committed Oct 4, 2014
    [trev.norris@gmail.com: break lines at 80 characters]
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
  2. crypto: createDiffieHellman throw for bad args

    trevnorris committed Oct 8, 2014
    Previously crypto.createDiffieHellman() would fail silently when a bad
    argument was passed for prime/prime_length. Now throws TypeError.
    
    Fixes: #8480
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
  3. test: fix debug-signal-cluster after da update

    indutny committed Oct 8, 2014
    The cluster children are hitting breakpoint at `cluster.onread` and
    hanging on a Semaphore wait now. This prevents them from disconnecting
    gracefully. Considering that the test is checking different thing, the
    cluster children needs to be force killed from the grand parent process.
    
    Reviewed-By: Trevor Norris <trevnorris@gmail.com>
    PR-URL: #8476
  4. src, test: fixup after v8 update

    indutny committed Oct 8, 2014
    Because of behavior change of some V8 APIs (they mostly became more
        strict), following modules needed to be fixed:
    
    * crypto: duplicate prototype methods are not allowed anymore
    * contextify: some TryCatch trickery, the binding was using it
    incorrectly
    * util: maximum call stack error is now crashing in a different place
    
    Reviewed-By: Trevor Norris <trevnorris@gmail.com>
    PR-URL: #8476
  5. cluster: do not signal children in debug mode

    indutny committed Oct 4, 2014
    Do not send signal to children if they are already in debug mode.
    Node.js on Windows does not register signal handler, and thus calling
    `process._debugProcess()` will throw an error.
    
    Reviewed-By: Trevor Norris <trevnorris@gmail.com>
    PR-URL: #8476
  6. deps: re-implement debugger-agent

    indutny committed Oct 4, 2014
    Reviewed-By: Trevor Norris <trevnorris@gmail.com>
    PR-URL: #8476
  7. deps: fix postmortem-metadata generator in v8

    refack authored and indutny committed Sep 29, 2014
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    PR-URL: #8476
  8. deps: apply floating irhydra patch to v8

    indutny committed Oct 2, 2014
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    PR-URL: #8476
  9. deps: update v8 to 3.28.73

    refack authored and indutny committed Sep 29, 2014
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
    PR-URL: #8476
  10. tls_wrap: ignore ZERO_RETURN after close_notify

    indutny committed Oct 6, 2014
    Do not call SSL_read() and ignore ZERO_RETURN if the connection was
    shutdown and there could not be any reads.
    
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    PR-URL: #8519
  11. buffer, doc: misc. fix and cleanup

    trevnorris committed Oct 8, 2014
    * Add official documentation that a Buffer instance is a viable
      argument when instantiating a new Buffer.
    * Properly set the poolOffset when a buffer needs to be truncated.
    * Add comments clarifying specific peculiar coding choices.
    * Remove a level of unnecessary indentation.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
  12. src: update use of ExternalArrayType constants

    trevnorris committed Oct 8, 2014
    Continuation of 4809c7a to update the use of v8::ExternalArrayType.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
  13. tools: fix for testing openssl integrations

    refack authored and trevnorris committed Oct 2, 2014
    Windows doesn't resolve ".." the way we expect it for symlinks and
    junctions.
    
    PR-URL: #8489
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
  14. src: fix jslint warning

    trevnorris committed Oct 8, 2014
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
  15. smalloc: update use of ExternalArrayType constants

    trevnorris committed Oct 8, 2014
    The constants in enum v8::ExternalArrayType have been changed. The old
    values are there for legacy reasons, but it's best to update anyway.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
  16. doc: add missing semicolons

    stevemao authored and trevnorris committed Oct 3, 2014
    PR-URL: #8498
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
  17. streams: set default encoding for writable streams

    Johnny Ray authored and trevnorris committed Oct 7, 2014
    Add API Writable#setDefaultEncoding().
    
    PR-URL: #8483
    Fixes: #7159
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Commits on Oct 7, 2014
  1. build: i18n: py27 -> py26 dependency

    srl295 authored and trevnorris committed Oct 4, 2014
    Move from argparse to optparse for dependency management.
    
    Fixes: #7719 (comment)
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
  2. build: i18n: move noisy variables to separate gypi

    srl295 authored and trevnorris committed Oct 4, 2014
    Fixes: #7676 (comment)
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
  3. url: fixed encoding for slash switching emulation.

    Evan Rutledge Borden authored and chrisdickinson committed Sep 26, 2014
    Fixes: #8458
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
  4. doc: improve readLine.pause()

    geon authored and chrisdickinson committed Mar 30, 2014
    The docs for readLine.pause are misleading. I seriously spent hours on this. If
    it isn't a bug, at least it should be well documented.
    
    Someone else stumbled on this too:
    http://stackoverflow.com/questions/21341050/pausing-readline-in-node-js
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
  5. doc: Update net.markdown

    steve-prod authored and chrisdickinson committed Sep 28, 2014
    Associates link to dns.lookup() with proper URL.
    
    Fixes: #8018
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
Commits on Oct 3, 2014
  1. util: add es6 Symbol support for `util.inspect`

    gyson authored and chrisdickinson committed Oct 1, 2014
    * `util.inspect` cannot accept es6 symbol primitive
    * It will throw exception if do `util.inspect(Symbol())`
    * This also affects repl, console.log, etc.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
  2. buffer: add generic functions for (u)int ops

    yorkie authored and trevnorris committed Oct 2, 2014
    Add generic functions for (U)Int read/write operations on Buffers. These
    support up to and including 48 bit reads and writes.
    
    Include documentation and tests.
    
    Additional work done by Trevor Norris to include 40 and 48 bit write
    support. Because bitwise operations cannot be used on values greater
    than 32 bits, the operations have been replaced with mathematical
    calculations. Regardless, they are still faster than floating point
    operations.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Commits on Oct 1, 2014
  1. buffer: mv floating point read/write checks to JS

    trevnorris committed Oct 1, 2014
    Performance improvement by moving checks for floating point operations
    to JS and doing the operation on a protected internal function that
    assumes all arguments are correct. Still abort if the operation
    overflows memory. This can only be caused if the Buffer's length
    property isn't the same as the actual internal length.
    
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
  2. readline: should not require an output stream.

    Julien Gilli authored and trevnorris committed Sep 22, 2014
    Passing null as the output stream to readline.Interface()'s constructor
    is now supported. Any output written by readline is just discarded. It
    makes it easier to use readline just as a line parser.
    
    Fixes: #4408
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
  3. node: avoid automatic microtask runs

    vkurchatkin authored and trevnorris committed Sep 22, 2014
    Since we are taking control of the microtask queue it makes sense to
    disable autorun and only run microtasks when necessary. Just setting
    isolate->SetAutorunMicrotasks(false) would cause _tickCallback() not to
    be called.
    
    Automatically running the microtask queue will cause it to run:
    
    * After callback invocation
    * Inside _tickCallback()
    * After _tickCallback() invocation
    
    The third one is unnecessary as the microtask queue is guaranteed to be
    empty at this point. The first only needs to be run manually when
    _tickCallback() isn't going to be called by MakeCallback().
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
  4. url: make query() consistent

    gwicke authored and trevnorris committed Sep 25, 2014
    Match the behavior of the slow path by setting url.query to an empty
    object when the url contains no query, but query parsing is requested.
    
    Also add a test for this case, and update the documents to clearly
    reflect this behavior.
    
    Fixes: #8332
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
  5. build, i18n: improve Intl build, add "--with-intl"

    srl295 authored and trevnorris committed Sep 5, 2014
    The two main goals of this change are:
     - To make it easier to build the Intl option using ICU (particularly,
       using a newer ICU than v8/Chromium's version)
     - To enable a much smaller ICU build with only English support The goal
       here is to get node.js binaries built this way by default so that the
       Intl API can be used. Additional data can be added at execution time
       (see Readme and wiki)
    
    More details are at #7719
    
    In particular, this change adds the "--with-intl=" configure option to
    provide more ways of building "Intl":
     - "full-icu" picks up an ICU from deps/icu
     - "small-icu" is similar, but builds only English
     - "system-icu" uses pkg-config to find an installed ICU
     - "none" does nothing (no Intl)
    
    For Windows builds, the "full-icu" or "small-icu" options are added to
    vcbuild.bat.
    
    Note that the existing "--with-icu-path" option is not removed from
    configure, but may not be used alongside the new option.
    
    Wiki changes have already been made on
     https://github.com/joyent/node/wiki/Installation
    and a new page created at
     https://github.com/joyent/node/wiki/Intl
    (marked as provisional until this change lands.)
    
    Summary of changes:
    
    * README.md : doc updates
    
    * .gitignore : added "deps/icu" as this is the location where ICU is
      unpacked to.
    
    * Makefile : added the tools/icu/* files to cpplint, but excluded a
      problematic file.
    
    * configure : added the "--with-intl" option mentioned above.
      Calculate at config time the list of ICU source files to use and data
      packaging options.
    
    * node.gyp : add the new files src/node_i18n.cc/.h as well as ICU
      linkage.
    
    * src/node.cc : add call into
      node::i18n::InitializeICUDirectory(icu_data_dir) as well as new
      --icu-data-dir option and NODE_ICU_DATA env variable to configure ICU
      data loading. This loading is only relevant in the "small"
      configuration.
    
    * src/node_i18n.cc : new source file for the above Initialize..
      function, to setup ICU as needed.
    
    * tools/icu : new directory with some tools needed for this build.
    
    * tools/icu/icu-generic.gyp : new .gyp file that builds ICU in some new
      ways, both on unix/mac and windows.
    
    * tools/icu/icu-system.gyp : new .gyp file to build node against a
      pkg-config detected ICU.
    
    * tools/icu/icu_small.json : new config file for the "English-only" small
      build.
    
    * tools/icu/icutrim.py : new tool for trimming down ICU data. Reads the
      above .json file.
    
    * tools/icu/iculslocs.cc : new tool for repairing ICU data manifests
      after trim operation.
    
    * tools/icu/no-op.cc : dummy file to force .gyp into using a C++ linker.
    
    * vcbuild.bat : added small-icu and full-icu options, to call into
      configure.
    
    * Fixed toolset dependencies, see
      #7719 (comment)
    
    Note that because of a bug in gyp {CC,CXX}_host must also be set.
    Otherwise gcc/g++ will be used by default for part of the build.
    
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
  6. doc: note stdout and stderr special behaviors.

    julien-f authored and chrisdickinson committed Sep 23, 2014
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>