Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Jul 6, 2013
  1. @bnoordhuis

    lib, src: upgrade after v8 api change

    bnoordhuis authored
    This is a big commit that touches just about every file in the src/
    directory. The V8 API has changed in significant ways. The most
    important changes are:
    * Binding functions take a const v8::FunctionCallbackInfo<T>& argument
      rather than a const v8::Arguments& argument.
    * Binding functions return void rather than v8::Handle<v8::Value>. The
      return value is returned with the args.GetReturnValue().Set() family
      of functions.
    * v8::Persistent<T> no longer derives from v8::Handle<T> and no longer
      allows you to directly dereference the object that the persistent
      handle points to. This means that the common pattern of caching
      oft-used JS values in a persistent handle no longer quite works,
      you first need to reconstruct a v8::Local<T> from the persistent
      handle with the Local<T>::New(isolate, persistent) factory method.
    A handful of (internal) convenience classes and functions have been
    added to make dealing with the new API a little easier.
    The most visible one is node::Cached<T>, which wraps a v8::Persistent<T>
    with some template sugar. It can hold arbitrary types but so far it's
    exclusively used for v8::Strings (which was by far the most commonly
    cached handle type.)
Commits on Apr 19, 2013
  1. @trevnorris @bnoordhuis

    src: replace Holder() with This()

    trevnorris authored bnoordhuis committed
    Switch to always use args.This() to retrieve object instance.
Commits on Mar 23, 2013
  1. @tjfontaine @bnoordhuis

    fs: uv_[fl]stat now reports subsecond resolution

    tjfontaine authored bnoordhuis committed
    While libuv supports reporting subsecond stat resolution across
    platforms, to actually get that resolution your platform and filesystem
    must support it (not HFS, ext[23], fat), otherwise the nsecs are 0
Commits on Mar 20, 2013
  1. @trevnorris @bnoordhuis

    src: pass Isolate to all applicable api

    trevnorris authored bnoordhuis committed
    Update the api to pass node_isolate to all supported methods.
    Much thanks to Ben Noordhuis and his work in 51f6e6a.
  2. @trevnorris @bnoordhuis

    bindings: update api

    trevnorris authored bnoordhuis committed
    All compile time warnings about using deprecated APIs have been
    suppressed by updating node's API. Though there are still many function
    calls that can accept Isolate, and still need to be updated.
    node_isolate had to be added as an extern variable in node.h and
    Also a couple small fixes for Error handling.
    Before v8 3.16.6 the error stack message was lazily written when it was
    needed, which allowed you to change the message after instantiation.
    Then the stack would be written with the new message the first time it
    was accessed. Though that has changed. Now it creates the stack message
    on instantiation. So setting a different message afterwards won't be
    This is not a complete fix for the problem. Getting error without any
    message isn't very useful.
Commits on Feb 25, 2013
  1. @bnoordhuis
Commits on Jan 7, 2013
  1. @bnoordhuis
  2. @bnoordhuis
Commits on Aug 20, 2012
  1. @bnoordhuis

    fs: fix use after free in stat watcher

    bnoordhuis authored
    The uv_fs_poll_t handle was stopped but not closed, leaving libuv's internal
    handle queue in a corrupted state.
Commits on Jun 21, 2012
  1. @bnoordhuis
  2. @bnoordhuis
Commits on Apr 17, 2012
  1. @isaacs
Commits on Mar 30, 2012
  1. @bnoordhuis
Commits on Mar 23, 2012
  1. @bnoordhuis

    Avoiding unnecessary ToString() calls

    ssuda authored bnoordhuis committed
    String::Utf8Value and String::AsciiValue constructors take Handle<Value>
    So no need to convert to Handle<String>
Commits on Mar 9, 2012
  1. @bnoordhuis
Commits on Jul 19, 2011
  1. @ry
Commits on Mar 15, 2011
  1. @ry

    Update copyright headers

    ry authored
Commits on Dec 20, 2010
  1. @piscisaureus

    Re-enable stat watchers on windows

    piscisaureus authored
    This reverts commit b8a99f94167a25f63ae096d9d5e2cc9cf70cecef.
  2. @piscisaureus
Commits on Sep 29, 2010
  1. @bnoordhuis @ry

    Safe constructor for ObjectWrapped classes

    bnoordhuis authored ry committed
    New() methods should be invoked as constructors, not regular functions.
    Corner cases like Script::New() may cause a SIGSEGV when the GC is run.
    More details:
Commits on May 10, 2010
  1. @ry

    Revert "Check for strings.h"

    ry authored
    This reverts commit 032f651.
  2. @ry

    Check for strings.h

    ry authored
Commits on Mar 15, 2010
  1. @ry

    Fix StatWatcher typo

    ry authored
  2. @ry

    Use uniform watcher names

    ry authored
Something went wrong with that request. Please try again.