Skip to content
Commits on May 17, 2013
  1. @isaacs

    Merge remote-tracking branch 'ry/v0.10' into v0.10-merge

    isaacs committed
Commits on May 16, 2013
  1. @trevnorris

    fs_event: use cached Persistent syms instead

    trevnorris committed
    Instead of String::New every time, use a Persistent sym. This can be
    accomplished in two ways:
    1) Local<String> str = *persistent_str_sym;
    2) Handle<String> str = persistent_str_sym;
    I've chosen to use the latter method for simplicity's sake.
    Other small changes include creating syms on Initialize and removing
    unnecessary Local casting on return values.
  2. @trevnorris

    src: add node_isolates

    trevnorris committed
    Few primitives weren't being passed node_isolate. Adding them for
  3. @bnoordhuis

    buffer, crypto: fix default encoding regression

    bnoordhuis committed
    The default encoding is 'buffer'. When the input is a string, treat it
    as 'binary'. Fixes the following assertion:
      node: ../src/ static size_t
      node::StringBytes::StorageSize(v8::Handle<v8::Value>, node::encoding):
      Assertion `0 && "buffer encoding specified but string provided"'
    Introduced in 64fc34b.
    Fixes #5482.
  4. @okuryu @bnoordhuis
  5. @okuryu @bnoordhuis
Commits on May 15, 2013
  1. @trevnorris

    http: don't slice unless necessary

    trevnorris committed
    The incoming Buffer was being sliced just to possibly not be used.
    Instead place the .slice inside the conditional to not be created unless
  2. @tjfontaine
  3. @bnoordhuis

    timers: fix setInterval() assert

    bnoordhuis committed
    Test case:
      var t = setInterval(function() {}, 1);
      Assertion failed: (args.Holder()->InternalFieldCount() > 0),
      function Unref, file ../src/, line 78.
    setInterval() returns a binding layer object. Make it stop doing that,
    wrap the raw process.binding('timer_wrap').Timer object in a Timeout
    Fixes #4261.
  4. @robertkowalski @bnoordhuis

    module: use path.sep instead of custom solution

    robertkowalski committed with bnoordhuis
    Instead of using a custom solution for path delimiters we can use
    path.sep in Module._initPaths
  5. @bnoordhuis

    http: don't escape request path, reject bad chars

    bnoordhuis committed
    Commit 38149bb changes http.get() and http.request() to escape unsafe
    characters. However, that creates an incompatibility with v0.10 that
    is difficult to work around: if you escape the path manually, then in
    v0.11 it gets escaped twice. Change lib/http.js so it no longer tries
    to fix up bad request paths, simply reject them with an exception.
    The actual check is rather basic right now. The full check for illegal
    characters is difficult to implement efficiently because it requires a
    few characters of lookahead. That's why it currently only checks for
    spaces because those are guaranteed to create an invalid request.
    Fixes #5474.
  6. @bnoordhuis

    net: emit dns 'lookup' event before connect

    bnoordhuis committed
    net.connect() and net.createConnection() now emit a 'lookup' event
    after resolving the hostname but before connecting.
    Fixes #5418.
  7. @bnoordhuis

    deps: fix up header files in cares.gyp

    bnoordhuis committed
    Please msbuild, update the header list.
  8. @bnoordhuis
  9. @rmg @bnoordhuis

    doc: improve exports/module.exports consistency

    rmg committed with bnoordhuis
    While they reference the same object, they are only interchangeable
    for updates, not assignment.
  10. @rmg @bnoordhuis

    doc: clarify exports and module.exports

    rmg committed with bnoordhuis
    When exporting a single function you must use `module.exports` instead
    of the `exports` convenience reference.
  11. @piscisaureus

    uv: upgrade to v0.11.3

    piscisaureus committed
Commits on May 14, 2013
  1. @piscisaureus

    uv: upgrade to v0.10.7

    piscisaureus committed
  2. @isaacs

    uv: Upgrade to 0.10.6

    isaacs committed
  3. @isaacs

    npm: Upgrade to 1.2.21

    isaacs committed
  4. @isaacs

    blog: Release 0.10.6

    isaacs committed
  5. @isaacs

    Now working on v0.10.7

    isaacs committed
  6. @isaacs
  7. @tjfontaine

    dns: add getServers and setServers

    tjfontaine committed
    getServers returns an array of ips that are currently being used for
    setServers takes an array of ips that are to be used for resolution,
    this will throw if there's invalid input but preserve the original
  8. @isaacs
  9. @isaacs

    2013.05.14, Version 0.10.6 (Stable)

    isaacs committed
    * module: Deprecate require.extensions (isaacs)
    * stream: make Readable.wrap support objectMode, empty streams (Daniel Moore)
    * child_process: fix handle delivery (Ben Noordhuis)
    * crypto: Fix performance regression (isaacs)
    * src: DRY string encoding/decoding (isaacs)
  10. @isaacs
  11. @isaacs

    crypto: use StringBytes::Encode

    isaacs committed
  12. @isaacs
  13. @isaacs

    buffer: DRY string encoding using StringBytes

    isaacs committed
    This also templatizes the Buffer::*Slice functions, and the template
    function probably cannot be safely used outside of Node.  However, it
    also SHOULD not be used outside of Node, so this is arguably a feature
    as well as a caveat.
  14. @isaacs

    src: use StringBytes for DecodeWrite/DecodeBytes/Encode

    isaacs committed
    Bonus: this makes node::Encode actually work properly with base64,
    ucs2, hex, etc.
  15. @isaacs
  16. @isaacs

    src: Add StringBytes static util class

    isaacs committed
    Four functions:
    - StringBytes::StorageSize()
    - StringBytes::Size()
    - StringBytes::Write()
    - StringBytes::Encode()
  17. @isaacs

    tools: remove unnecessary cpplint rules

    isaacs committed
    We don't actually care about header order much, and since we never use
    stl classes, 'string' isn't an issue for node ever.
  18. @isaacs

    stream: Make default encoding configurable

    isaacs committed
    Pretty much everything assumes strings to be utf-8, but crypto
    traditionally used binary strings, so we need to keep the default
    that way until most users get off of that pattern.
Something went wrong with that request. Please try again.