This repository has been archived by the owner. It is now read-only.
Permalink
Switch branches/tags
Commits on May 23, 2015
  1. 2015.05.22, Version 0.12.4 (Stable)

    Julien Gilli
    Julien Gilli committed May 23, 2015
    * npm: upgrade to 2.10.1
    
    * V8: revert v8 Array.prototype.values() removal (cjihrig)
    
    * win: bring back xp/2k3 support (Bert Belder)
  2. deps: upgrade to npm 2.10.1

    iarna authored and Julien Gilli committed May 22, 2015
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #25364
Commits on May 22, 2015
  1. win: bring back xp/2k3 support

    piscisaureus authored and Julien Gilli committed Jan 19, 2015
    Issue: #25348
    The gyp/project files don't explicitly specify a subsystem version,
    which results in the default being used. The default changed from
    VS 2010 to VS 2012 and later.
    
    Backport e8d0850 from io.js.
    Original commit message follows:
    
    Chrome still runs on Windows XP, so there is no reason that iojs
    couldn't.
    
    PR: nodejs/node#512
    (cherry picked from commit e8d0850)
    
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #25367
  2. test: Array.prototype.values() regression test

    cjihrig authored and Julien Gilli committed May 15, 2015
    This commit adds a regression test for
    #25324
    
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #25328
  3. deps: revert v8 Array.prototype.values() removal

    cjihrig authored and Julien Gilli committed May 15, 2015
    The Node 0.12 line was initially released with a version
    of v8 that included Array.prototype.values(). In
    #18206, v8 was
    updated to a version that dropped support for values().
    https://codereview.chromium.org/647703003 removed this
    method because it causes problems with some versions of
    Outlook Web Access. This commit reverts the removal of
    Array.prototype.values().
    
    Original commit message:
    
    Revert "Version 3.28.71.17 (merged r24706, r24708)"
    
    This reverts commit 529541ecb58fd0d6df4dfbe41d01bff9ae21ff06.
    
    Conflicts:
    	src/version.cc
    
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #25328
Commits on May 21, 2015
  1. doc: Using ciphers with tls.connect()

    iamthechad authored and mhdawson committed May 12, 2015
    Refs #25270,#25271
    
    Reviewed-By: Michael Dawson <mhdawsonibm@gmail.com>
    PR-URL: #25325
Commits on May 14, 2015
  1. test: relax timing constraints for child process

    gireeshpunathil authored and mhdawson committed May 13, 2015
    With additional load in the system, the child process which runs sleep
    command takes more time to run - typically slightly above 1 second,
    but above 2 seconds under stress.
    
    While the intent of the test is to test the functionality of spawnSync
    and the child process in general, in effect it is testing the system
    command sleep, and further, it's responsiveness.
    
    Since from the name the purpose of the test seems to be unrelated to
    the sleep behaviour, I believe a more meaningful assertion would be to
    see the time taken is more than 1 second.
    
    Reviewed-By: Michael Dawson <mhdawsonibm@gmail.com>
    PR-URL: #25291
  2. test: delete simple/test-process-active-wraps

    mhdawson committed May 14, 2015
    This test currently fails when run on machines without
    IPv6 enabled. Futher it was delete in io.js under
    3143d73 as the test
    was known to have problems across platforms and
    releases.
    
    The existing test was hard to understand so I wrote
    a new version but then found exactly what was
    reported in the io.js pull request.  Behaviour varies
    across platforms such that writing a solid test would
    either be infeasible or test so little that
    it does not seem to make sense to keep it.
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    PR-URL: #25326
  3. Now working on 0.12.4

    Julien Gilli
    Julien Gilli committed May 14, 2015
  4. Merge branch 'v0.12.3-release' into v0.12

    Julien Gilli
    Julien Gilli committed May 14, 2015
  5. 2015.05.13, Version 0.12.3 (Stable)

    Julien Gilli
    Julien Gilli committed May 14, 2015
    * V8: update to 3.28.71.19
    
    * uv: upgrade to 1.5.0
    
    * npm: upgrade to 2.9.1
    
    * V8: don't busy loop in v8 cpu profiler thread (Mike Tunnicliffe)
    
    * V8: fix issue with let bindings in for loops (adamk)
    
    * debugger: don't spawn child process in remote mode (Jackson Tian)
    
    * net: do not set V4MAPPED on FreeBSD (Julien Gilli)
    
    * repl: make 'Unexpected token' errors recoverable (Julien Gilli)
    
    * src: backport ignore ENOTCONN on shutdown race (Ben Noordhuis)
    
    * src: fix backport of SIGINT crash fix on FreeBSD (Julien Gilli)
Commits on May 13, 2015
  1. tls,crypto: revert recent cipher lists changes

    Julien Gilli
    Julien Gilli committed May 13, 2015
    Revert "disable RC4, add --cipher-list command line switch" and
    "tls: make --enable-legacy-cipher-list=val less verbose"
    
    This reverts commit f9291a9 and
    b5737bb.
    
    There is still some work to be done to guarantee secure defaults and a
    smooth upgrade path for v0.12.x users. Before this work is finished, we
    want to be able to release new versions of v0.12.x. So instead of
    waiting for these changes to be ready to ship, revert them and integrate
    them when they're ready to be shipped.
    
    Conflicts:
    	src/node.cc
    
    Reviewed-By: James M Snell <jasnell@gmail.com>
    PR-URL: #25296
  2. deps: upgrade npm to 2.9.1

    othiym23 authored and Julien Gilli committed May 12, 2015
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #25289
  3. repl: make 'Unexpected token' errors recoverable

    Julien Gilli
    Julien Gilli committed Dec 15, 2014
    Fix the regexp used to detect 'Unexpected token' errors so that they can
    be considered as recoverable. This fixes the following use case:
    
    > var foo = 'bar \
    ... baz';
    undefined
    > foo
    'bar baz'
    >
    
    Fixes #8874
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    PR-URL: #8875
Commits on May 12, 2015
  1. test,win: disable test-tls-server-verify for CI

    orangemocha committed May 12, 2015
    test-tls-server-verify takes a lont time to execute and times
    out on the Jenkins machines.
    
    Reviewed-By: James M Snell <jasnell@gmail.com>
    PR-URL: #25284
  2. deps: don't busy loop in v8 cpu profiler thread

    tunniclm authored and Julien Gilli committed May 8, 2015
    Backport 6964a9e0685fa186d9d9b7907be17505e839db1a from upstream v8.
    
    Original commit message:
    
      Make CPU profiler do not hog 100% of CPU.
    
      Tick event processor should not stay in a tight loop
      when there's nothing to do. It can go sleep until next sample event.
    
      LOG=N
      BUG=v8:3967
      Committed: https://crrev.com/6964a9e0685fa186d9d9b7907be17505e839db1a
      Cr-Commit-Position: refs/heads/master@{#28211}
    
    Fixes #25137
    Related: #9439, #8789
    
    PR: #25268
    PR-URL: #25268
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
  3. build: fix use of strict aliasing

    trevnorris authored and Julien Gilli committed Feb 10, 2015
    The -fno-strict-aliasing flag was added to fix compilation warnings when
    building Node.js with GCC <= 4.4
    
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #9179
    
    PR: #25141
    PR-URL: #25141
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
  4. deps: update libuv to 1.5.0

    saghul authored and Julien Gilli committed May 6, 2015
    PR: #25141
    PR-URL: #25141
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
Commits on May 6, 2015
  1. test: Extend timeout due to failure on AIX

    mhdawson committed May 6, 2015
    The loopback on AIX is slower by default than on other platforms
    and we've seen a number of tests fail on AIX for this reason. This
    looks to be another instance.  Changing the test to bind to the
    host ip instead of the loopback makes it pass reliably.
    
    This change extends the timeout so that it passes reliably on AIX
    even with the slower loopback behaviour
    
    	modified:   test/simple/test-tls-wrap-timeout.js
    
    Reviewed-By: coln Ihrig <cjihrig@gmail.com>
    PR-URL: #25138
Commits on May 1, 2015
  1. deps: upgrade npm to 2.8.4

    othiym23 authored and Julien Gilli committed Apr 24, 2015
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #20311
Commits on Apr 30, 2015
  1. test: make test-npm uses custom node, not global

    Julien Gilli
    Julien Gilli committed Jan 28, 2015
    When running make test-npm, make would use the node binary available in
    the PATH, which would most of the time not be the same binary as the one
    built from the source tree from where the make test-npm command in run.
    
    This can be confusing, as it can lead users to think that they tested
    npm with the version of node that was built from the current checkout of
    the source tree when it would actually run the tests with a completely
    different version.
    
    This change modifies the PATH environment variable for all commands that
    need to run the node binary to run npm's tests by adding the root of the
    local checkout as the first entry, so that the custom built node is
    always used.
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    PR-URL: #9107
  2. test: add test for let bindings in for loops

    Julien Gilli
    Julien Gilli committed Apr 28, 2015
    0724602 floats a patch on V8 that fixes
    issue #9113 that would cause let bindings and continue statements in for
    loops to not work properly.
    
    This change adds a regression test that fails if that patch is not
    properly floated, thus preventing us from not floating that patch after
    future V8 upgrades.
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    PR-URL: #23948
  3. v8: fix issue with let bindings in for loops

    ajklein authored and Julien Gilli committed Nov 14, 2014
    Backport b17eaaa5755e625493c5fe537f42b58838923c52 from upstream v8.
    
    Original commit message:
      Fix desugaring of let bindings in for loops to handle continue properly
    
      This requires putting the original loop's body inside an inner for loop (with
      the same labels as the original loop) and re-binding the temp variables in its
      "next" expression. A second flag is added to the desugared code to ensure the
      loop body executes at most once per loop.
    
      BUG=v8:3683
      LOG=y
    
      Review URL: https://codereview.chromium.org/720863002
    
      Cr-Commit-Position: refs/heads/master@{#25363}
    
    Fixes #9113 and #14411.
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    PR-URL: #23948
Commits on Apr 29, 2015
  1. build: fix build for SmartOS

    Julien Gilli
    Julien Gilli committed Oct 9, 2014
    This change in V8: https://code.google.com/p/v8/source/detail?r=22210
    has introduced a method named OS::GetCurrentThreadId which fails to
    compile on OSes where a "gettid" syscall does not exist.
    
    This build issue has been fixed upstream by several changes:
    - https://code.google.com/p/v8/source/detail?r=23459.
    - https://codereview.chromium.org/649553002
    - https://codereview.chromium.org/642223003
    
    Another minor fix to the upstream changes was also necessary.
    See https://code.google.com/p/v8/issues/detail?id=3620 for
    more information.
    
    The other build issue was due to the fact that alloca.h is not included
    by other system includes on SmartOS, which is assumed by V8.
    
    Built and tested on Linux, MacOS X, Windows and SmartOS.
    
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    PR-URL: #18206
  2. deps: backport use strict fix for V8 debugger

    yury-s authored and Julien Gilli committed Nov 19, 2014
    Backport 2ad2237507c5b5f9047b8d94d2f4997327eae852 from V8.
    
    Original commit message:
    
      Fix Unhandled ReferenceError in debug-debugger.js
    
      This fixes following exception in Sky on attempt to set a breakpoint
      "Unhandled: Uncaught ReferenceError: break_point is not defined"
      I think this happens in Sky but not in Chrome because Sky scripts are executed in strict mode.
    
      BUG=None
      LOG=N
      R=yangguo@chromium.org
    
      Review URL: https://codereview.chromium.org/741683002
    
      Cr-Commit-Position: refs/heads/master@{#25415}
    
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    PR-URL: #18206
  3. mdb_v8: fix dictionary properties access

    davepacheco authored and Julien Gilli committed Oct 23, 2014
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    PR-URL: #18206
  4. deps: fix postmortem-metadata generator in v8

    refack authored and Julien Gilli committed Sep 29, 2014
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    PR-URL: #18206
  5. deps: apply floating irhydra patch to v8

    trevnorris authored and Julien Gilli committed Feb 11, 2015
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    PR-URL: #18206
  6. deps: update V8 to 3.28.71.19

    trevnorris authored and Julien Gilli committed Feb 11, 2015
    The 3.28.73 update was technically unstable code. This reverts the code
    to the latest 3.28 stable release.
    
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    PR-URL: #18206
Commits on Apr 28, 2015
  1. net: do not set V4MAPPED on FreeBSD

    Julien Gilli
    Julien Gilli committed Mar 2, 2015
    V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
    Thus, do not set this flag in net.connect on FreeBSD.
    
    Fixes #8540 and #9204.
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    PR-URL: #18204
Commits on Apr 23, 2015
  1. build,win: set env before generating projects

    orangemocha committed Apr 23, 2015
    vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
    so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
    defaults to 'auto' and selects VS 2005.
    
    vcbuild sets the environment in the current shell, so this issue
    would manifest itself only on the first invocation of the script
    in any given shell windows.
    
    Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
    PR-URL: #20109
Commits on Apr 14, 2015
  1. src: fix backport for SIGINT crash fix on FreeBSD

    Julien Gilli
    Julien Gilli committed Apr 14, 2015
    61fe1fe backported
    b64983d from io.js, but failed to
    change nullptr to NULL, which lead to a build break on FreeBSD since the
    current build system doesn't enable support for C++11.
    
    This change replaces nullptr by NULL, and has been tested on
    FreeBSD 10.1-RELEASE-p8.
    
    Fixes #9326.
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    PR-URL: #14819
  2. debugger: don't spawn child process in remote mode

    JacksonTian authored and Julien Gilli committed Mar 26, 2015
    When debug in remote mode with host:port or pid, the interface
    spawn child process also. If the debugger agent is running, will
    get following output:
    
    ```
    < Error: listen EADDRINUSE :::5858
    <     at Object.exports._errnoException (util.js:734:11)
    <     at exports._exceptionWithHostPort (util.js:757:20)
    <     at Agent.Server._listen2 (net.js:1155:14)
    <     at listen (net.js:1181:10)
    <     at Agent.Server.listen (net.js:1268:5)
    <     at Object.start (_debug_agent.js:21:9)
    <     at startup (node.js:68:9)
    <     at node.js:799:3
    ```
    
    This fix won't spawn child process and no more error message was
    shown.
    
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #14172
  3. debugger: improve help information

    JacksonTian authored and Julien Gilli committed Mar 26, 2015
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #14172
Commits on Apr 13, 2015
  1. src: backport ignore ENOTCONN on shutdown race

    bnoordhuis authored and mhdawson committed Mar 19, 2015
    This is a backport of ea37ac0
    
    Original commit message:
    
      On AIX, OS X and the BSDs, calling shutdown() on one end of a pipe
      when the other end has closed the connection fails with ENOTCONN.
    
      The sequential/test-child-process-execsync test failed sporadically
      because of a race between the parent and the child where one closed
      its end of the pipe before the other got around to calling shutdown()
      on its end of the pipe.
    
      Libuv is not the right place to handle that because it can't tell if
      the ENOTCONN error is genuine but io.js can.
    
      Refs: libuv/libuv#268
      PR-URL: iojs#1214
      Reviewed-By: Bert Belder <bertbelder@gmail.com>
    
    Fixes: #9444.
    
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #14480