Skip to content
Commits on Apr 8, 2013
  1. @isaacs

    2013.04.09, Version 0.8.23 (maintenance)

    isaacs committed
    * npm: Upgrade to v1.2.18
    
    * http: Avoid EE warning on ECONNREFUSED handling (isaacs)
    
    * tls: Re-enable check of CN-ID in cert verification (Tobias Müllerleile)
    
    * child_process: fix sending utf-8 to child process (Ben Noordhuis)
    
    * crypto: check key type in GetPeerCertificate() (Ben Noordhuis)
    
    * win/openssl: mark assembled object files as seh safe (Bert Belder)
    
    * windows/msi: fix msi build issue with WiX 3.7/3.8 (Raymond Feng)
  2. @isaacs

    npm: Upgrade to v1.2.18

    isaacs committed
  3. @isaacs

    http: Avoid EE warning on ECONNREFUSED handling

    isaacs committed
    This is a back-port of the same fix in
    deb1dc279d49463e13af44feed45c79ae0f379f9, for v0.8.
Commits on Apr 7, 2013
  1. @tmuellerleile @indutny

    tls: Re-enable check of CN-ID in cert verification

    tmuellerleile committed with indutny
    RFC 6125 explicitly states that a client "MUST NOT seek a match
    for a reference identifier of CN-ID if the presented identifiers
    include a DNS-ID, SRV-ID, URI-ID, or any application-specific
    identifier types supported by the client", but it MAY do so if
    none of the mentioned identifier types (but others) are present.
Commits on Mar 25, 2013
  1. @bnoordhuis

    child_process: fix sending utf-8 to child process

    bnoordhuis committed
    In process#send() and child_process.ChildProcess#send(), use 'utf8' as
    the encoding and correctly handle partial character sequences by
    introducing a StringDecoder. Before this commit, it used 'ascii' and
    partial sequences were dropped or corrupted.
    
    This is a back-port of commit 44843a6 from the v0.10 branch.
    
    Fixes #4999 and #5011.
Commits on Mar 13, 2013
  1. @bnoordhuis

    crypto: check key type in GetPeerCertificate()

    bnoordhuis committed
    Works around the following exception:
    
      Error: 140463203215168:error:0607907F:digital envelope
      routines:EVP_PKEY_get1_RSA:expecting an rsa key:
      ../deps/openssl/openssl/crypto/evp/p_lib.c:288:
        at CleartextStream._pusher (tls.js:656:24)
        at SlabBuffer.use (tls.js:199:18)
        at CleartextStream.CryptoStream._push (tls.js:483:33)
        at SecurePair.cycle (tls.js:880:20)
        <snip>
    
    The issue has been solved properly in v0.10 and the master branch as of
    commit c6e2db2 ("crypto: clear error stack"). This is the "back-port"
    to v0.8.
    
    For some (rather unquantifiable) reason the original fix only works for
    the tls module in v0.8 but not the https module unless OpenSSL is
    downgraded to 0.9.8. Upgrading OpenSSL does *not* fix it, however.
    
    The https module doesn't appear to be at fault; upgrading it to v0.10
    doesn't fix the issue. That leaves either the tls or the http module
    (that https derives from) but the changes to those modules are too
    massive to back-port as-is.
    
    `git bisect` over the v0.8 -> v0.10 commits didn't show up anything
    useful, it pinpoints c6e2db2 as the commit that fixes things.
    
    I've spent several hours on this now and seeing that v0.8 is in
    maintenance mode, this cheap hack will have to do.
    
    Fixes #4771.
Commits on Mar 8, 2013
  1. @piscisaureus

    Revert "build, windows: disable SEH"

    piscisaureus committed
    This is no longer necessary - the underlying issue was fixed in 01fa5ee.
    This reverts commit d879042.
  2. @piscisaureus

    win/openssl: mark assembled object files as seh safe

    piscisaureus committed
    There are no unsafe structured exception handlers in object files
    generated from hand-crafted assembly - because they contain no exception
    handlers at all.
  3. @raymondfeng @piscisaureus

    windows/msi: fix msi build issue with WiX 3.7/3.8

    raymondfeng committed with piscisaureus
    The `heat` tool that gathers NPM source files wasn't getting called.
    Closes #4896
Commits on Mar 7, 2013
  1. @isaacs

    blog: Post for v0.8.22

    isaacs committed
  2. @isaacs

    Now working on 0.8.23

    isaacs committed
  3. @isaacs
Commits on Mar 6, 2013
  1. @isaacs

    2013.03.07, Version 0.8.22 (Stable)

    isaacs committed
    * npm: Update to 1.2.14
    
    * cluster: propagate bind errors (Ben Noordhuis)
    
    * crypto: don't assert when calling Cipher#final() twice (Ben Noordhuis)
    
    * build, windows: disable SEH (Ben Noordhuis)
  2. @isaacs

    npm: Update to 1.2.14

    isaacs committed
  3. @isaacs
  4. @isaacs

    blog: Post for 0.9.12

    isaacs committed
  5. @TooTallNate

    process: invoke EventEmitter on `process`

    TooTallNate committed
    This properly sets the `_maxListeners` property, which
    fixes the max listener warning. Closes #4924.
Commits on Mar 5, 2013
  1. @bnoordhuis

    cluster: propagate bind errors

    bnoordhuis committed
    This commit fixes a bug where the cluster module fails to propagate
    EADDRINUSE errors.
    
    When a worker starts a (net, http) server, it requests the listen socket
    from its master who then creates and binds the socket.
    
    Now, OS X and Windows don't always signal EADDRINUSE from bind() but
    instead defer the error until a later syscall. libuv mimics this
    behaviour to provide consistent behaviour across platforms but that
    means the worker could end up with a socket that is not actually bound
    to the requested addresss.
    
    That's why the worker now checks if the socket is bound, raising
    EADDRINUSE if that's not the case.
    
    Fixes #2721.
Commits on Mar 4, 2013
  1. @bnoordhuis
  2. @rvagg @isaacs
Commits on Mar 2, 2013
  1. @bnoordhuis

    test: make simple/test-dgram-pingpong respect PORT

    bnoordhuis committed
    Don't use hard-coded port numbers, use common.PORT instead.
    
    Should fix the occasional Jenkins failure; the builds run in parallel.
  2. @tjfontaine @bnoordhuis

    test: optionally set common.PORT via env variable

    tjfontaine committed with bnoordhuis
    This is a back-port of commit 17a8126 from the master branch.
  3. @bnoordhuis

    crypto: don't assert when calling Cipher#final() twice

    bnoordhuis committed
    Remove the assert() that triggered when Cipher#final() or
    Decipher#final() was called twice.
    
    Fixes #4886.
Commits on Mar 1, 2013
  1. @isaacs

    blog: Post about v0.9.11

    isaacs committed
  2. @bnoordhuis

    http: use socket.once, not socket.on

    bnoordhuis committed
    Register the 'close' event listener with .once(), not .on().
    
    It doesn't matter in the grand scheme of things because the listener
    doesn't keep references to any heavy-weight objects but using .once()
    for a oneshot listener is something of a best practice.
Commits on Feb 28, 2013
  1. @egirshov @bnoordhuis
  2. @tjfontaine @bnoordhuis

    test: fix tap output on windows

    tjfontaine committed with bnoordhuis
    Test output is always \n and not platform dependent
  3. @bnoordhuis

    build, windows: disable SEH

    bnoordhuis committed
    Turn off safe exception handlers, they're incompatible with how
    openssl is compiled / linked under MSVS 2012.
    
    Addresses the following build error:
    
      openssl.lib(x86cpuid.obj) : error LNK2026: module unsafe for SAFESEH
      image. [g:\jenkins\workspace\nodejs-oneoff\node.vcxproj]
      openssl.lib(x86.obj) : error LNK2026: module unsafe for SAFESEH
      image. [g:\jenkins\workspace\nodejs-oneoff\node.vcxproj]
      # etc. etc.
      g:\jenkins\workspace\nodejs-oneoff\Release\node.exe : fatal error
      LNK1281: Unable to generate SAFESEH image.
      [g:\jenkins\workspace\nodejs-oneoff\node.vcxproj]
    
    Fixes #4242.
  4. @bnoordhuis

    doc: update instructions on home page

    bnoordhuis committed
    Document how to run the example on the home page in more detail.
    
    Apparently our Windows brethren are prone to double-clicking on the
    binary instead of running it from the command line.
    
    Fixes #4854.
Commits on Feb 25, 2013
  1. @isaacs
  2. @isaacs
  3. @isaacs

    blog: Post for v0.8.21

    isaacs committed
  4. @isaacs

    Now working on 0.8.22

    isaacs committed
  5. @isaacs
  6. @isaacs

    2013.02.25, Version 0.8.21 (Stable)

    isaacs committed
    * http: Do not free the wrong parser on socket close (isaacs)
    
    * http: Handle hangup writes more gently (isaacs)
    
    * zlib: fix assert on bad input (Ben Noordhuis)
    
    * test: add TAP output to the test runner (Timothy J Fontaine)
    
    * unix: Handle EINPROGRESS from domain sockets (Ben Noordhuis)
Something went wrong with that request. Please try again.