‘SSL_COMP_get_compression_methods’ was not declared in this scope #1242

Closed
bnoordhuis opened this Issue Jun 28, 2011 · 3 comments

Comments

Projects
None yet
2 participants
Owner

bnoordhuis commented Jun 28, 2011

The #ifdef check for SSL_COMP_get_compression_methods in node_crypto.cc (added for #1087) apparently succeeds with some versions of OpenSSL that don't actually implement or export it.

/usr/bin/g++ -pthread -arch i386 -m32 -g -O3 -DHAVE_OPENSSL=1 -DEV_FORK_ENABLE=0 -DEV_EMBED_ENABLE=0 -DEV_MULTIPLICITY=0 -DX_STACKSIZE=65536 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DEV_MULTIPLICITY=0 -DHAVE_FDATASYNC=0 -DPLATFORM="darwin" -D__POSIX__=1 -Wno-unused-parameter -D_FORTIFY_SOURCE=2 -Idefault/src -I../src -Idefault/deps/libeio -I../deps/libeio -Idefault/deps/http_parser -I../deps/http_parser -Idefault/deps/v8/include -I../deps/v8/include -Idefault/deps/libev -I../deps/libev -Idefault/deps/c-ares -I../deps/c-ares -Idefault/deps/c-ares/darwin-ia32 -I../deps/c-ares/darwin-ia32 -Ideps/v8/include ../src/node_crypto.cc -c -o default/src/node_crypto_4.o
../src/node_crypto.cc: In function ‘void node::crypto::InitCrypto(v8::Handle<v8::Object>)’:
../src/node_crypto.cc:2917: error: ‘SSL_COMP_get_compression_methods’ was not declared in this scope

Should probably be a feature check in the wscript file.

http://pastebin.com/S8t8BnhA

@bnoordhuis bnoordhuis added a commit to bnoordhuis/node that referenced this issue Jul 3, 2011

@bnoordhuis bnoordhuis Check if OpenSSL supports SSL_COMP_get_compression_methods().
Fixes #1242.
649c1e8

japj commented Jul 20, 2011

anything blocking this from being pulled into master?

Owner

bnoordhuis commented Jul 20, 2011

@ry or @pquerna - review please!

@bnoordhuis bnoordhuis added a commit to bnoordhuis/node that referenced this issue Jul 20, 2011

@bnoordhuis bnoordhuis crypto: check for SSL_COMP_get_compression_methods()
Function was named SSL_COMP_get_compression_method() (singular)
in OpenSSL 0.9.7 and older.

Fixes #1242.
cf654df
Owner

bnoordhuis commented Jul 20, 2011

Okay, we're going with 6f0740e - no feature check needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment