This repository has been archived by the owner. It is now read-only.

querystring.parse shouldn't include stuff from Object.prototype #1497

thejh opened this Issue Aug 11, 2011 · 1 comment


None yet
2 participants

thejh commented Aug 11, 2011

Dunno whether it should error out or just set the property, but including prototype methods seems wrong.

[jann@Jann-PC node]$ node
> require("querystring").parse("toString=foo&valueOf=bar&__defineGetter__=baz")
{ toString: [ [Function: toString], 'foo' ],
  valueOf: [ [Function: valueOf], 'bar' ],
  __defineGetter__: [ [Function: __defineGetter__], 'baz' ] }

isaacs commented Aug 11, 2011

Yeah, it should set the property. that's a bug.

@isaacs isaacs closed this in 3210809 Aug 11, 2011

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.