Skip to content
This repository has been archived by the owner. It is now read-only.

compression and TLS #1523

Closed
Dededede4 opened this issue Aug 13, 2011 · 7 comments
Closed

compression and TLS #1523

Dededede4 opened this issue Aug 13, 2011 · 7 comments
Labels

Comments

@Dededede4
Copy link

@Dededede4 Dededede4 commented Aug 13, 2011

Hello,
I have another little question about the TLS module.
It is possible to enable compression?

Thank you!

@pquerna
Copy link

@pquerna pquerna commented Aug 13, 2011

Currently node.js disables all compression, as seen here:

https://github.com/joyent/node/blob/master/src/node_crypto.cc#L3873-3893

This is done globally, on startup, because for most node.js use cases, using >512kb of ram for each tls connection is bad -- there currently isn't a good way to disable it per-connection, especially with older versions of openssl that are quite common.

Loading

@Dededede4 Dededede4 closed this Aug 13, 2011
@skepticfx
Copy link

@skepticfx skepticfx commented Dec 14, 2013

There are good use cases when we want TLS compression enabled. Any good alternatives would be much appreciated.

Loading

@indutny
Copy link
Member

@indutny indutny commented Dec 14, 2013

No, there're no really good use cases for it. Compression in TLS is really flawed since it can't check if underlying content is already compressed, or if it is "compressable" at all. This is widely accepted, that compression should be done at application level, instead of the protocol level.

Loading

@andytson
Copy link

@andytson andytson commented Dec 29, 2013

I'd also add that TLS compression also adds CRIME vulnerability. http://en.wikipedia.org/wiki/CRIME_(security_exploit). Glad Node didn't already use it.

Loading

@skepticfx
Copy link

@skepticfx skepticfx commented Dec 29, 2013

@andytson Absolutely, #6709

I wanted TLS Compression enabled for testing some CRIME related stuff. Probably, that was a bad call. I'm glad, @indutny made https://github.com/indutny/tls.js , which solves my problem in a way

Loading

@indutny
Copy link
Member

@indutny indutny commented Dec 29, 2013

Does it? :)

Loading

@skepticfx
Copy link

@skepticfx skepticfx commented Dec 29, 2013

Well, I wanted a way to send and receive client hellos and server hellos with TLS compression enabled. The parser and framer in tls.js can be used to do what I want. There are a few hiccups here and there, will file about them in its issue list.

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants