Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

url.parse().host should not contain auth #1626

Closed
isaacs opened this Issue Sep 1, 2011 · 2 comments

Comments

Projects
None yet
3 participants

isaacs commented Sep 1, 2011

It makes sense for the url.parse().host to contain the port number, since that's the tradition of window.location. However, tacking the auth in there as well doesn't make sense. Since window.location never sees the auth section (as that's actually the Athorization: Basic header), we sort of just did the same thing as with port, and stuck it on host.

But it's making things harder than necessary for #1390

@ghost ghost assigned isaacs Sep 1, 2011

@seebees seebees added a commit to seebees/node-1 that referenced this issue Oct 15, 2011

@seebees seebees remove auth from host
Fixes #1626
a17edf5

@koichik koichik closed this in 1ead20f Oct 22, 2011

aseemk commented Apr 27, 2012

Ouch, was bitten by this -- the current "latest" documentation (8 months later) says otherwise:

host: The full lowercased host portion of the URL, including port and authentication information.
Example: 'user:pass@host.com:8080'

http://nodejs.org/docs/latest/api/url.html

But I see the change was made before 0.6, and the docs are fixed in master. Is it worth updating the docs on the site for all 0.6.x versions? Sucks to have wrong docs. =/

aseemk commented Jun 13, 2012

I see that the docs have been fixed — commit cb9898a. Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment