AssertionError in IncomingMessage 'end' listener #1892

Closed
OrangeDog opened this Issue Oct 14, 2011 · 4 comments

Projects

None yet

3 participants

@OrangeDog

Node v0.4.11 after a server we are communicating with terminates the connection due to too large a request.

uncaughtException: undefined
Stack: AssertionError: true == false
    at IncomingMessage.<anonymous> (http.js:1341:9)
    at IncomingMessage.emit (events.js:81:20)
    at HTTPParser.onMessageComplete (http.js:133:23)
    at Socket.ondata (http.js:1231:22)
    at Socket._onReadable (net.js:683:27)
    at IOWatcher.onReadable [as callback] (net.js:177:10)

Assertion in question is

if (socket.writable) {
  debug('AGENT socket.destroySoon()');
  socket.destroySoon();
}
assert(!socket.writable);
@koichik

Thanks for the report. This has fixed in v0.5 (with libuv backend).
Socket.destroySoon() sets writable to false immediately.
Closing.

@koichik koichik closed this Oct 17, 2011
@OrangeDog

When is 0.5.x going to become stable? If it is known this assertion is invalid, should it not be removed in a patch to 0.4.x?

@aikar

soon (the github milestone lists today as due date...), ry has said their likely will not be another 0.4.x release.

@koichik

@OrangeDog - Ryan did not seem to want to release v0.4 anymore.

@ry - If there is a plan to release v0.4, please reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment