Socket.pause null reference when called on a closed Stream #1980

Closed
olegp opened this Issue Nov 1, 2011 · 6 comments

Projects

None yet

3 participants

@olegp

I get the error below when calling pause on a Stream that's already closed in Node 0.5.10:

TypeError: Cannot call method 'readStop' of null
    at Socket.pause (net.js:177:16)

This was not resulting in such an error before.

@koichik koichik added a commit to koichik/node that referenced this issue Nov 1, 2011
@koichik koichik net: fix Socket.pause null reference when called on a closed Stream
Fixes #1980.
0ad8944
@koichik

review?

@koichik koichik added a commit to koichik/node that referenced this issue Dec 27, 2011
@koichik koichik net: fix Socket.pause null reference when called on a closed Stream
Fixes #1980.
b3dc6f2
@koichik

@bnoordhuis Thanks! I fixed what you pointed out. Can you review koichik/node@b3dc6f2?

@bnoordhuis
Node.js Foundation member

@koichik: LGTM

@koichik

@bnoordhuis Thanks, merging.

@koichik koichik closed this in a848a3e Dec 28, 2011
@koichik

@olegp Thanks for the report, merged in a848a3e.

@isaacs isaacs added a commit to isaacs/node that referenced this issue Jan 6, 2012
@isaacs isaacs 2012.01.06, Version 0.6.7 (stable)
* Upgrade V8 to 3.6.6.15

* Upgrade npm to 1.1.0-beta-10 (isaacs)

* many doc updates (Ben Noordhuis, Jeremy Martin, koichik, Dave Irvine,
  Seong-Rak Choi, Shannen, Adam Malcontenti-Wilson, koichik)

* #2438 segfault in node v0.6.6

* dgram, timers: fix memory leaks (Ben Noordhuis, Yoshihiro Kukuchi)

* repl: fix repl.start not passing the `ignoreUndefined` arg (Damon Oehlman)

* #1980: Socket.pause null reference when called on a closed Stream (koichik)

* #2263: XMLHttpRequest piped in a writable file stream hang (koichik)

* #2069: http resource leak (koichik)

* buffer.readInt global pollution fix (Phil Sung)

* timers: fix performance regression (Ben Noordhuis)

* #2308, #2246: node swallows openssl error on request (koichik)

* #2114: timers: remove _idleTimeout from item in .unenroll() (James Hartig)

* #2379: debugger: Request backtrace w/o refs (Fedor Indutny)

* simple DTrace ustack helper (Dave Pacheco)

* crypto: rewrite HexDecode without snprintf (Roman Shtylman)

* crypto: add SecureContext.clearOptions() method (Ben Noordhuis)

* crypto: don't ignore DH init errors (Ben Noordhuis)
f15ef99
@isaacs isaacs added a commit that referenced this issue Jan 7, 2012
@isaacs isaacs 2012.01.06, Version 0.6.7 (stable)
* V8 hash collision fix (Breaks MIPS) (Bert Belder, Erik Corry)

* Upgrade V8 to 3.6.6.15

* Upgrade npm to 1.1.0-beta-10 (isaacs)

* many doc updates (Ben Noordhuis, Jeremy Martin, koichik, Dave Irvine,
  Seong-Rak Choi, Shannen, Adam Malcontenti-Wilson, koichik)

* Fix segfault in node_http_parser.cc

* dgram, timers: fix memory leaks (Ben Noordhuis, Yoshihiro Kukuchi)

* repl: fix repl.start not passing the `ignoreUndefined` arg (Damon Oehlman)

* #1980: Socket.pause null reference when called on a closed Stream (koichik)

* #2263: XMLHttpRequest piped in a writable file stream hang (koichik)

* #2069: http resource leak (koichik)

* buffer.readInt global pollution fix (Phil Sung)

* timers: fix performance regression (Ben Noordhuis)

* #2308, #2246: node swallows openssl error on request (koichik)

* #2114: timers: remove _idleTimeout from item in .unenroll() (James Hartig)

* #2379: debugger: Request backtrace w/o refs (Fedor Indutny)

* simple DTrace ustack helper (Dave Pacheco)

* crypto: rewrite HexDecode without snprintf (Roman Shtylman)

* crypto: don't ignore DH init errors (Ben Noordhuis)
d5a189a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment