Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

support dtrace probes with GYP build system #2110

Closed
ry opened this Issue · 8 comments

6 participants

@ry
ry commented

No description provided.

@bnoordhuis
Owner

In case someone wants to take this one, I already did some work on this:

https://github.com/bnoordhuis/node/compare/gyp-dtrace

Not 100% functional but close-ish.

@ry
ry commented

this still need help. cc @davepacheco @rmustacc @isaacs

@bnoordhuis bnoordhuis was assigned
@doc

Any updates on this ... would really like to have a set of function probes for node.

@davepacheco

@doc To be clear, this project (as I understand it) doesn't add any new probes. It makes the probes that already existed under node 0.6 work on master, which was broken by the move from waf to gyp.

@isaacs
Owner

@davepacheco @doc That's my understanding as well. We just need to un-break the probes that were broken by moving to gyp.

@doc

@davepacheco got it, thanks for the context. That said, the 0.6 dtrace support only works on Solaris (and family) according to the configure script when run with the --with-dtrace option.

@rmustacc

@doc That's because there are bugs in the Mac OS X implementation which cause it to break. No one has tested with FreeBSD 9 yet.

@davepacheco davepacheco referenced this issue from a commit in davepacheco/node
@davepacheco davepacheco add GYP support for DTrace probes
Fixes #2110
73cd7b4
@davepacheco

I've got this working, along with support for postmortem metadata (under aaff8c3). There's one more related piece I want to do next, which is ustack helper support, and then I'll submit a pull request for all three.

@davepacheco davepacheco referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@davepacheco davepacheco referenced this issue from a commit in davepacheco/node
@davepacheco davepacheco add GYP support for DTrace probes
Fixes #2110
1d44295
@davepacheco davepacheco referenced this issue from a commit in davepacheco/node
@davepacheco davepacheco add GYP support for DTrace and postmortem
Fixes #2110
includes V8 postmortem metadata in Solaris builds
adds GYP support for DTrace probes and ustack helper
ustack helper derives constants dynamically from libv8_base.a
build with DTrace support by default on SunOS
514d682
@bnoordhuis bnoordhuis closed this issue from a commit
@davepacheco davepacheco build: add support for DTrace and postmortem
* fixes #2110
* includes V8 postmortem metadata in Solaris builds
* adds GYP support for DTrace probes and ustack helper
* ustack helper derives constants dynamically from libv8_base.a
* build with DTrace support by default on SunOS
cc15299
@bnoordhuis bnoordhuis closed this in cc15299
@skomski skomski referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@ErikDubbelboer ErikDubbelboer referenced this issue from a commit
@davepacheco davepacheco build: add support for DTrace and postmortem
* fixes #2110
* includes V8 postmortem metadata in Solaris builds
* adds GYP support for DTrace probes and ustack helper
* ustack helper derives constants dynamically from libv8_base.a
* build with DTrace support by default on SunOS
2e63abb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.