support dtrace probes with GYP build system #2110

Closed
ry opened this Issue Nov 15, 2011 · 8 comments

Projects

None yet

6 participants

@ry
ry commented Nov 15, 2011

No description provided.

@bnoordhuis
Member

In case someone wants to take this one, I already did some work on this:

https://github.com/bnoordhuis/node/compare/gyp-dtrace

Not 100% functional but close-ish.

@ry
ry commented Jan 18, 2012

this still need help. cc @davepacheco @rmustacc @isaacs

@bnoordhuis bnoordhuis was assigned Mar 3, 2012
@doc
doc commented Mar 15, 2012

Any updates on this ... would really like to have a set of function probes for node.

@davepacheco

@doc To be clear, this project (as I understand it) doesn't add any new probes. It makes the probes that already existed under node 0.6 work on master, which was broken by the move from waf to gyp.

@isaacs
isaacs commented Mar 15, 2012

@davepacheco @doc That's my understanding as well. We just need to un-break the probes that were broken by moving to gyp.

@doc
doc commented Mar 15, 2012

@davepacheco got it, thanks for the context. That said, the 0.6 dtrace support only works on Solaris (and family) according to the configure script when run with the --with-dtrace option.

@rmustacc

@doc That's because there are bugs in the Mac OS X implementation which cause it to break. No one has tested with FreeBSD 9 yet.

@davepacheco davepacheco added a commit to davepacheco/node that referenced this issue Mar 28, 2012
@davepacheco davepacheco add GYP support for DTrace probes
Fixes #2110
73cd7b4
@davepacheco

I've got this working, along with support for postmortem metadata (under aaff8c3). There's one more related piece I want to do next, which is ustack helper support, and then I'll submit a pull request for all three.

@davepacheco davepacheco added a commit to davepacheco/node that referenced this issue Mar 31, 2012
@davepacheco davepacheco add GYP support for DTrace probes
Fixes #2110
1d44295
@davepacheco davepacheco added a commit to davepacheco/node that referenced this issue Mar 31, 2012
@davepacheco davepacheco add GYP support for DTrace and postmortem
Fixes #2110
includes V8 postmortem metadata in Solaris builds
adds GYP support for DTrace probes and ustack helper
ustack helper derives constants dynamically from libv8_base.a
build with DTrace support by default on SunOS
514d682
@bnoordhuis bnoordhuis added a commit that closed this issue Apr 1, 2012
@davepacheco @bnoordhuis davepacheco + bnoordhuis build: add support for DTrace and postmortem
* fixes #2110
* includes V8 postmortem metadata in Solaris builds
* adds GYP support for DTrace probes and ustack helper
* ustack helper derives constants dynamically from libv8_base.a
* build with DTrace support by default on SunOS
cc15299
@bnoordhuis bnoordhuis closed this in cc15299 Apr 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment