Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
GYP build fails on Solaris #2123
Building using gyp doesn't work at all on my Solaris system, specifically Solaris 10u8.
There are two issues I encountered:
I was able to get round this by adding a solaris section in deps/v8/tools/gyp/v8.gyp that builds platform-solaris.cc and platform-posix.cc, and links against -lsocket and -lrt
Newer Solaris ld actually understand the gnu options and map them to ld's own options, but that's fairly recent.
-Wl,--start-group => -z rescan-start
however, older ld only has a single '-z rescan' rather than the start/end pair
Patch (works for me, but I'm not that familiar with gyp): http://www.petertribble.co.uk/Solaris/node-gyp-solaris.diff
Peter, can you check the v0.6 branch? It compiles for me now on illumos with the GNU toolchain.
Do you know why you need -lsocket and -lrt? The build works fine for me without.
Re: the gyp patch - I'm kind of loath to take it. It a) doesn't apply and b) I want to keep the delta with upstream gyp as small as possible. Can you send it to the gyp-developers mailing list?
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Regular v0.6 works fine for me, on Solaris 10, and I produce packages for that.
I'm specifically testing master to see what sort of impact the changes to the build systems are going to have.
As for -lsocket -lrt, it may be that Illumos has merged those into libc (which Sun should have done years ago); they're definitely needed on Solaris 10.
I wasn't expecting you to take the patch straight off - I'll continue plugging away.
Okay, I'll add them. Are they specific to V8 or does the whole build need them? I would assume the latter but your patch adds them to v8.gyp.