This repository has been archived by the owner. It is now read-only.

v0.6.1 not compiling on smartos #2140

Closed
ry opened this Issue Nov 17, 2011 · 3 comments

Comments

Projects
None yet
3 participants
@ry

ry commented Nov 17, 2011

[32/35] cxx: src/node_io_watcher.cc -> out/Release/src/node_io_watcher_5.o
/opt/local/bin/g++ -threads -m32 -g -O3 -DHAVE_OPENSSL=1 -DSUNOS_HAVE_IFADDRS -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAVE_FDATASYNC=1 -DARCH="ia32" -DPLATFORM="sunos" -D__POSIX__=1 -Wno-unused-parameter -D_FORTIFY_SOURCE=2 -IRelease/src -I../src -IRelease/deps/http_parser -I../deps/http_parser -IRelease/deps/uv/include -I../deps/uv/include -IRelease/deps/uv/src/ares -I../deps/uv/src/ares -IRelease/deps/v8/include -I../deps/v8/include -Ideps/v8/include ../src/node_io_watcher.cc -c -o Release/src/node_io_watcher_5.o
In file included from ../src/node_io_watcher.h:25:0,
                 from ../src/node_io_watcher.cc:22:
../src/node_object_wrap.h:30:19: error: variable 'node::NODE_EXTERN node::ObjectWrap' has initializer but incomplete type
../src/node_object_wrap.h:30:19: warning: extended initializer lists only available with -std=c++0x or -std=gnu++0x
../src/node_object_wrap.h:31:2: error: expected primary-expression before 'public'
../src/node_object_wrap.h:31:2: error: expected '}' before 'public'
../src/node_object_wrap.h:31:2: error: expected ',' or ';' before 'public'
../src/node_object_wrap.h:37:23: error: expected class-name before '(' token
In file included from /usr/include/sys/time.h:471:0,
                 from /usr/include/sys/select.h:49,
                 from /usr/include/sys/types.h:629,
                 from /usr/include/signal.h:40,
                 from Release/deps/uv/include/uv-private/ev.h:152,
                 from ../src/node_io_watcher.h:26,
                 from ../src/node_io_watcher.cc:22:
/usr/include/time.h:285:49: error: expected '}' before end of line
/usr/include/time.h:285:49: error: expected declaration before end of line
Waf: Leaving directory `/root/node/out'
Build failed:  -> task failed (err #1): 
        {task: cxx node_io_watcher.cc -> node_io_watcher_5.o}
make: *** [program] Error 1

@ghost ghost assigned ry Nov 17, 2011

@ry

This comment has been minimized.

Show comment Hide comment
@ry

ry Nov 17, 2011

here's the fix

diff --git a/src/node.h b/src/node.h
index 1d32237..cb58a22 100644
--- a/src/node.h
+++ b/src/node.h
@@ -62,6 +62,7 @@
 #include <v8.h>
 #include <sys/types.h> /* struct stat */
 #include <sys/stat.h>
+#include <assert.h>

 #include <node_object_wrap.h>

diff --git a/src/node_object_wrap.h b/src/node_object_wrap.h
index d76dd59..0ead639 100644
--- a/src/node_object_wrap.h
+++ b/src/node_object_wrap.h
@@ -22,6 +22,7 @@
 #ifndef object_wrap_h
 #define object_wrap_h

+#include <node.h>
 #include <v8.h>
 #include <assert.h>

ry commented Nov 17, 2011

here's the fix

diff --git a/src/node.h b/src/node.h
index 1d32237..cb58a22 100644
--- a/src/node.h
+++ b/src/node.h
@@ -62,6 +62,7 @@
 #include <v8.h>
 #include <sys/types.h> /* struct stat */
 #include <sys/stat.h>
+#include <assert.h>

 #include <node_object_wrap.h>

diff --git a/src/node_object_wrap.h b/src/node_object_wrap.h
index d76dd59..0ead639 100644
--- a/src/node_object_wrap.h
+++ b/src/node_object_wrap.h
@@ -22,6 +22,7 @@
 #ifndef object_wrap_h
 #define object_wrap_h

+#include <node.h>
 #include <v8.h>
 #include <assert.h>
@pizthewiz

This comment has been minimized.

Show comment Hide comment
@pizthewiz

pizthewiz Nov 17, 2011

this issue also affects Mac OS X 10.7 and the proposed fix seems to do the trick.

this issue also affects Mac OS X 10.7 and the proposed fix seems to do the trick.

@bnoordhuis

This comment has been minimized.

Show comment Hide comment
@bnoordhuis

bnoordhuis Nov 17, 2011

Member

Fixed in v0.6 for illumos in 2c52cce and 4f8a0cd. Note that these are existing patches that got lost in V8 upgrades.

Member

bnoordhuis commented Nov 17, 2011

Fixed in v0.6 for illumos in 2c52cce and 4f8a0cd. Note that these are existing patches that got lost in V8 upgrades.

@ry ry closed this in b0030af Nov 17, 2011

@ry ry removed their assignment Aug 31, 2015

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.