Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Build fails when options.gypi modified because gyp looks in the wrong directory for makefile autoregen. #2147

Closed
adammw opened this Issue · 2 comments

4 participants

@adammw

Basically, if options.gypi is modified after ./configure is ran, gyp attempts to regenerate the makefile, however because the makefile is in the out/ folder, ./tools/gyp_node isn't the correct path.
Gyp provides a variable toplevel_dir in WriteAutoRegenerationRule (gyp/pylib/gyp/generator/make.py) but I'm not sure where that should be set, just that it has to be set because at the moment it doesn't work.

@bnoordhuis bnoordhuis was assigned
@ry
ry commented

yes, this is annoying

@eddyb eddyb referenced this issue from a commit
eddyb Fix #2147. 509342b
@eddyb eddyb referenced this issue
Closed

Fix #2147. #2221

@eddyb

I tried to make this work with gyp, but it seems that it's more or less hard-coded on a Chromium-like build environment.
The easiest fix for this is to add this in the top Makefile (and possibly remove the call from configure):

out/Makefile: common.gypi deps/uv/uv.gyp deps/http_parser/http_parser.gyp deps/zlib/zlib.gyp deps/v8/build/common.gypi deps/v8/tools/gyp/v8.gyp node.gyp options.gypi
    tools/gyp_node -f make
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.