This repository has been archived by the owner. It is now read-only.

Could you handle this udp error 10054 in windows? #2177

Closed
longbai opened this Issue Nov 24, 2011 · 4 comments

Comments

Projects
None yet
2 participants
@longbai

longbai commented Nov 24, 2011

refer support.microsoft.com/kb/263823 socket error 10054

I am not sure this is an issue or feature. When I write a udp server, if a client is die, the error callback will raise and the socket dit not use.

So how to handle it? Ignore it in nodejs layer by refer solution or reopen in js?

Thank you.

@longbai

This comment has been minimized.

Show comment Hide comment
@longbai

longbai Nov 24, 2011

I test again, when meet 10054, the socket would not recv, but sendto still work. I think nodejs could raise error, but do not deactive recv event on this socket.

longbai commented Nov 24, 2011

I test again, when meet 10054, the socket would not recv, but sendto still work. I think nodejs could raise error, but do not deactive recv event on this socket.

@longbai

This comment has been minimized.

Show comment Hide comment
@longbai

longbai Nov 24, 2011

I think it need add wagetlasterror() check in deps\win\udp.c. if lasterror is 10054, still add read pending in the socket in line 305. I do not know linux has same issue.

longbai commented Nov 24, 2011

I think it need add wagetlasterror() check in deps\win\udp.c. if lasterror is 10054, still add read pending in the socket in line 305. I do not know linux has same issue.

@piscisaureus

This comment has been minimized.

Show comment Hide comment
@piscisaureus

piscisaureus Nov 24, 2011

Member

Should be fixed in 7244b9c.

@kraftbai Let me know if it works for you now.

Member

piscisaureus commented Nov 24, 2011

Should be fixed in 7244b9c.

@kraftbai Let me know if it works for you now.

@longbai

This comment has been minimized.

Show comment Hide comment
@longbai

longbai Nov 25, 2011

Sorry, I have no gyp environment and vc, I cant test it.
Thanks.

longbai commented Nov 25, 2011

Sorry, I have no gyp environment and vc, I cant test it.
Thanks.

TooTallNate pushed a commit to TooTallNate/node that referenced this issue Nov 30, 2011

alexkwolfe added a commit to alexkwolfe/node that referenced this issue Dec 23, 2011

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.