Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

`test-stdin-resume-pause` hangs #2257

Closed
mmalecki opened this Issue Dec 3, 2011 · 1 comment

Comments

Projects
None yet
3 participants

mmalecki commented Dec 3, 2011

stdin isn't automatically terminated.

See #1934.

Member

indexzero commented Dec 5, 2011

+1 Any status on a fix here?

@isaacs isaacs closed this in cf20b6b Dec 6, 2011

isaacs added a commit to isaacs/node-v0.x-archive that referenced this issue Dec 6, 2011

Fix #2257 pause/resume semantics for stdin
Review please!

This makes it so that the stdin TTY-wrap stream gets ref'ed on
.resume() and unref'ed on .pause()

The semantics of the names "pause" and "resume" are a bit weird, but the
important thing is that this corrects an API change from 0.4 -> 0.6
which made it impossible to read from stdin multiple times, without
knowing when it might end up being closed.  If no one has it open, this
lets the process die naturally.

isaacs added a commit to isaacs/node-v0.x-archive that referenced this issue Dec 6, 2011

alexkwolfe added a commit to alexkwolfe/node that referenced this issue Dec 23, 2011

Fix #2257 pause/resume semantics for stdin
This makes it so that the stdin TTY-wrap stream gets ref'ed on
.resume() and unref'ed on .pause()

The semantics of the names "pause" and "resume" are a bit weird, but the
important thing is that this corrects an API change from 0.4 -> 0.6
which made it impossible to read from stdin multiple times, without
knowing when it might end up being closed.  If no one has it open, this
lets the process die naturally.

LGTM'd by @ry

alexkwolfe added a commit to alexkwolfe/node that referenced this issue Dec 23, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment