Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

GYP build of node (master branch) on OS X has incorrect `process.arch` #2518

Closed
TooTallNate opened this Issue Jan 11, 2012 · 0 comments

Comments

Projects
None yet
2 participants

Not a huge deal, but it would be nice to keep it consistent with the old waf builds. This broke a few modules of mine.

Good:

~ (master) $ node
> process.version
'v0.6.7'
> process.platform
'darwin'

Bad:

~ (master) $ ./node/node_g 
> process.version
'v0.7.0-pre'
> process.platform
'mac'

@TooTallNate TooTallNate added a commit to TooTallNate/node that referenced this issue Jan 11, 2012

@TooTallNate TooTallNate Set `process.platform` to "darwin" on OS X.
This is consistent with the old waf build system, and doesn't break old scripts
that are expecting the value to be "darwin".

Fixes #2518.
ac8a29e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment