.close() should take a callback.

[mikeal]

Realized that this is a lot of unnecessary boiler

var portrange = 45032

function getPort (cb) {
  var port = portrange
  portrange += 1

  var server = net.createServer()
  server.listen(port, function (err) {
    server.once('close', function () {
      cb(port)
    })
    server.close()
  })
  server.on('error', function (err) {
    getPort(cb)
  })
}

Listen takes a callback that just adds a listener for "listening", .close() should do the same, adding an event listener for "close".

I'm also debating in my head right now whether the listen callback should take an error. It would be a breaking change, but worth considering.

[bnoordhuis]

Listen takes a callback that just adds a listener for "listening", .close() should do the same, adding an event listener for "close".

Funny coincidence, I was discussing that with @mmalecki last night in #libuv. He couldn't convince me of a pressing need but if it makes the API more consistent without breaking existing code, I'm not against it.

[isaacs]

Landed on d530ee6. Thanks!