Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

64bit binary in the OS X installer. Still installs on 32bit machines. #2770

Closed
pygy opened this Issue Feb 17, 2012 · 2 comments

Comments

Projects
None yet
3 participants

pygy commented Feb 17, 2012

It would be nice if the OS X installer performed a CPU architecture check.

Member

bnoordhuis commented Feb 17, 2012

@isaacs: The node binary is i386 in node-v0.7.3.pkg but it's x86_64 in node-v0.6.10.pkg. Is that intentional?

On a general note, we should probably ship universal binaries, larger file sizes be damned.

isaacs commented Feb 17, 2012

Hm. Looks like the make pkg target in os x doesn't force the arch to ia32. It ought to. (Already does this on master.)

@bnoordhuis Yes, we should ship universals. But for now (that is, 0.6.11) it's probably best to just make it i386

@isaacs isaacs closed this in e16c6c7 Feb 17, 2012

bnoordhuis pushed a commit to bnoordhuis/node that referenced this issue Feb 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment