Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

dtrace ustack helper improvements #2852

Closed
davepacheco opened this Issue Mar 1, 2012 · 0 comments

Comments

Projects
None yet
2 participants

There are a few issues with the current DTrace ustack helper:

  • It sometimes produces incomplete output. Instead of saying "func at file.js position 123", it will say " at position 123". This turned out to be a result of catching V8 during GC, where it's twiddled the last bits of various pointers, causing the helper to read the wrong memory.
  • There are certain types of internal frames where there's a Code object rather than a JSFunction object on the stack. Currently, the helper simply doesn't translate it at all, leaving you with a hex address. This interferes with stack coalescing (as via Brendan Gregg's FlameGraph tools) because you see varying hex addresses in the stack, so they appear different even though they're pretty much indistinguishable to Node programmers.

I've already got fixes for these. There's a pull request coming shortly.

davepacheco added a commit to davepacheco/node that referenced this issue Mar 1, 2012

davepacheco added a commit to davepacheco/node that referenced this issue Mar 1, 2012

davepacheco added a commit to davepacheco/node that referenced this issue Mar 1, 2012

@isaacs isaacs closed this in edea94c Mar 2, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment