This repository has been archived by the owner. It is now read-only.

readline module should not append the 'escape' key to the current line #2876

Closed
joeferner opened this Issue Mar 5, 2012 · 4 comments

Comments

Projects
None yet
2 participants

If no modifier keys are pressed and a user presses the 'escape' key a bad character is emitted. The escape key should probably be ignored.

Example: Open a node REPL and hit the escape key.

Member

bnoordhuis commented Mar 5, 2012

If no modifier keys are pressed and a user presses the 'escape' key a bad character is emitted.

It doesn't for me. With what version of Node and on what operating system are you seeing this behavior?

I'm using v0.6.4 on linux. I also had someone try this on a mac. But on the mac it does not show the bad character, it does add the character to the line though. So if you type "1+(escape)1(enter)" the REPL does not think the line is complete and does not execute.

Member

bnoordhuis commented Mar 6, 2012

Right, I see what you mean and that issue still exists in the current master. Want to try your hand at a patch?

Southern added a commit to Southern/node that referenced this issue Mar 6, 2012

@Southern Southern referenced this issue Mar 6, 2012

Closed

Readline Fix #2881

Southern added a commit to Southern/node that referenced this issue Mar 6, 2012

@bnoordhuis bnoordhuis closed this in c84b3c4 Mar 7, 2012

Member

bnoordhuis commented Mar 7, 2012

Fixed in c84b3c4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.