Allow Steam.prototype.setEncoding() to be reverted #3639

Open
Rush opened this Issue Jul 5, 2012 · 6 comments

Projects

None yet

6 participants

Rush commented Jul 5, 2012

Expected behaviour: socket.setEncoding(null) sets socket._encoder = undefined;
Current behaviour: No behaviour.

Should be very easy to fix, should I send a patch for it? I am a bit unsure on how you work in here so I am a bit hesitant.

isaacs commented Jul 5, 2012

That sounds reasonable. Here's the steps:

  1. Sign the cla: http://nodejs.org/cla.html
  2. Fork, edit, add a test, update the docs, make a commit with a short meaningful message like Fix #3639 setEncoding(null) removes stream encoder
  3. Push to your fork
  4. Send pull request.

Thanks!

@Rush Rush added a commit to Rush/node that referenced this issue Jul 5, 2012
@Rush Rush Fix #3639 setEncoding(null) removes stream encoder 5f5d3c3
koichik commented Jul 7, 2012

related to #2533

@chrisdickinson chrisdickinson added the easy label Sep 30, 2014
cdlewis commented Oct 17, 2014

Is this issue still open given @RushPL's commit?

Rush@5f5d3c3

Rush commented Oct 17, 2014

Just checked, my test attached in the pull request fails with node 0.11.14. Can my pull request be finally merged after over 2 years lol? @isaacs @chrisdickinson

Owner
jasnell commented May 18, 2015

@joyent/node-coreteam ... this had a pull request but never seems to have landed (for unknown reasons). There doesn't seem to have been any objections noted so is this something we'd like to do or not?

Owner
jasnell commented Jun 24, 2015

@joyent/node-tsc ... ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment