Skip to content
This repository has been archived by the owner. It is now read-only.

Support SourceMap #3712

Closed
gfx opened this issue Jul 15, 2012 · 24 comments
Closed

Support SourceMap #3712

gfx opened this issue Jul 15, 2012 · 24 comments

Comments

@gfx
Copy link

@gfx gfx commented Jul 15, 2012

There comes more and more JavaScript source generation tools.
If nodejs support SourceMap, we'll be very happy. On Browsers, Chrome (19+) supports SourceMap and it works well.
(cf. INTRODUCTION TO JAVASCRIPT SOURCE MAPS)

(This ticket might be related to #2537)

@bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Jul 15, 2012

What's stopping you from writing a sourcemap module and publishing it on npm? I don't think there's anything in the sourcemap spec that requires it to be the a core module but please correct me if I'm wrong.

@bnoordhuis bnoordhuis closed this Jul 15, 2012
@gfx
Copy link
Author

@gfx gfx commented Jul 18, 2012

I'm sorry to my lack of explanations. I didn't mean to need sourcemap modules. There is already a stable sourcemap module: https://github.com/mozilla/source-map

Rather, I'd like to node to understand source-mapping information. How can we see correct line numbers and file names in runtime error messages when we use CoffeeScript? That's sourcemap and it is the interpreter which can process source-mapping files.

@bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Jul 18, 2012

Why would node need to do anything? Isn't that the task of the CS loader?

@gfx
Copy link
Author

@gfx gfx commented Jul 18, 2012

CoffeeScript is just an example and I doesn't use CS actually, sorry.

What I use is Google Closure Compiler and JSX, which are also support sourcemap output.

@bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Jul 18, 2012

Okay, thanks - that kind of clears it up for me. I doubt anyone on the core team has the time or the inclination to work on this but we'll entertain patches. I'll reopen the issue.

@bnoordhuis bnoordhuis reopened this Jul 18, 2012
@gfx
Copy link
Author

@gfx gfx commented Jul 18, 2012

Thank you very much! Anyway, it is the first step.

@martinheidegger
Copy link

@martinheidegger martinheidegger commented Dec 14, 2012

Right now having no correct file number of stacktraces from code created by the is annoying at best. I would very much welcome this feature: +1

@eldargab
Copy link

@eldargab eldargab commented Dec 18, 2012

+1

@Lewuathe
Copy link

@Lewuathe Lewuathe commented Dec 19, 2012

We'll be able to get more debug options on node development +1

@SystemParadox
Copy link

@SystemParadox SystemParadox commented Jan 7, 2013

+1, I've even made my own language that extends JavaScript, that's how common this is becoming

@devongovett
Copy link

@devongovett devongovett commented Feb 8, 2013

Here is a module that implements sourcemap support in user land https://github.com/evanw/node-source-map-support

@jashkenas
Copy link

@jashkenas jashkenas commented Mar 9, 2013

FWIW, it looks like @evanw's implementation is fairly minimal, and would probably be a good starting point for getting a patch landed into core: https://github.com/evanw/node-source-map-support/blob/master/source-map-support.js

... this would also help for development in terms of bringing the Node debugger closer to browser debuggers in terms of feature parity -- making it a bit more viable to develop and test libraries in just Node instead of in Chrome.

@TooTallNate
Copy link

@TooTallNate TooTallNate commented Mar 9, 2013

Because of the hacky way that this needs to be integrated into the V8 internal API, it seems to me that this belongs at the V8 level rather than node...

@gfx
Copy link
Author

@gfx gfx commented Jun 15, 2013

There's an npm to support source-map: https://github.com/evanw/node-source-map-support

I'd like to merge node-source-map-support into the NodeJS core.

@fresheneesz
Copy link

@fresheneesz fresheneesz commented Jun 29, 2013

It doesn't seem like evanw's node-source-map-support gives any real support for debugging. Is this issue about stack traces and debugging, or just the former?

@gfx
Copy link
Author

@gfx gfx commented Jun 29, 2013

@fresheneesz Ideally, yes, but partial support is better than nothing.

@realyze
Copy link

@realyze realyze commented Sep 10, 2013

+1 this

@doublerebel
Copy link

@doublerebel doublerebel commented Sep 15, 2013

👍

@jnordberg
Copy link

@jnordberg jnordberg commented Mar 22, 2014

👍

@kenjiru
Copy link

@kenjiru kenjiru commented Apr 14, 2014

Sourcemaps support would be really nice for debugging TypeScript modules. Thanks!

@patrickmesana
Copy link

@patrickmesana patrickmesana commented Oct 3, 2014

+1

@misterdai
Copy link

@misterdai misterdai commented Nov 6, 2014

👍 Would love sourcemap support. Currently using Traceur to transpile ES6/7 for Node, which can produce the sourcemap files but I can't make use of them.

@gsikorski
Copy link

@gsikorski gsikorski commented Feb 2, 2016

+1 For production server it is nice to browserify + minify the code of the backend as well (even including all node_modules installation), so that it occupies less space. Would be great if node supports printing the stack using provided source map.

@bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Apr 29, 2016

Closing, continues in nodejs/node#6471.

@bnoordhuis bnoordhuis closed this Apr 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet