v0.8.4 breaks ev-emul.h (at least with gcc 4.6.3 on smartos) #3786

Closed
mcavage opened this Issue Jul 28, 2012 · 1 comment

Projects

None yet

2 participants

@mcavage
mcavage commented Jul 28, 2012

In f6f2d42

the variadic macros were changed from ... to /* variadic */ which at least on my OS, results in this failure:

00:49:43-mcavage@gibson:~/work/node-zookeeper$ V=1 npm install

> zookeeper@3.4.1-4 install /home/mcavage/work/node-zookeeper
> node-gyp rebuild

make: Entering directory `/home/mcavage/work/node-zookeeper/build'
  LD_LIBRARY_PATH=/home/mcavage/work/node-zookeeper/build/Release/lib.host:/home/mcavage/work/node-zookeeper/build/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../.; sh libzk-build.sh
  touch Release/obj.target/libzk.stamp.node
  g++ '-D_LARGEFILE_SOURCE' '-D_FILE_OFFSET_BITS=64' '-D_POSIX_PTHREAD_SEMANTICS' -I/home/mcavage/.node-gyp/0.8.4/src -I/home/mcavage/.node-gyp/0.8.4/deps/uv/include -I/home/mcavage/.node-gyp/0.8.4/deps/v8/include -I/opt/local/include/zookeeper  -fPIC -Wall -m32 -pthreads -Wall -Werror -O0 -Wno-strict-aliasing -O2 -fno-strict-aliasing -fno-tree-vrp -ffunction-sections -fdata-sections -fno-omit-frame-pointer -fno-rtti -fno-exceptions -MMD -MF ./Release/.deps/Release/obj.target/zookeeper/src/node-zk.o.d.raw  -c -o Release/obj.target/zookeeper/src/node-zk.o ../src/node-zk.cpp
../src/node-zk.cpp: In member function 'void zk::ZooKeeper::yield()':
../src/node-zk.cpp:208:54: error: too many arguments to function 'double __ev_now()'
/home/mcavage/.node-gyp/0.8.4/src/ev-emul.h:233:22: note: declared here
../src/node-zk.cpp: In static member function 'static void zk::ZooKeeper::zk_timer_cb(__ev_timer*, int)':
../src/node-zk.cpp:256:58: error: too many arguments to function 'double __ev_now()'
/home/mcavage/.node-gyp/0.8.4/src/ev-emul.h:233:22: note: declared here
../src/node-zk.cpp: In member function 'bool zk::ZooKeeper::realInit(const char*, int, clientid_t*)':
../src/node-zk.cpp:288:38: error: too many arguments to function 'void __ev_set_priority()'
/home/mcavage/.node-gyp/0.8.4/src/ev-emul.h:238:20: note: declared here
make: *** [Release/obj.target/zookeeper/src/node-zk.o] Error 1
make: Leaving directory `/home/mcavage/work/node-zookeeper/build'

Can you please change those back to ... as that is known to work on basically every C compiler?

@bnoordhuis
Member

Can you please change those back to ... as that is known to work on basically every C compiler?

I changed it because gcc in -pedantic -Werror mode was choking on it. God, I hate compilers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment