Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

node v0.6.21 tarball on nodejs.org has incorrect NODE_VERSION_IS_RELEASE #3822

Closed
dougwilson opened this Issue Aug 4, 2012 · 4 comments

Comments

Projects
None yet
3 participants
Member

dougwilson commented Aug 4, 2012

The tarball on nodejs.org at http://nodejs.org/dist/v0.6.21/node-v0.6.21.tar.gz has the following in src/node_version.h:

#define NODE_MAJOR_VERSION 0
#define NODE_MINOR_VERSION 6
#define NODE_PATCH_VERSION 21
#define NODE_VERSION_IS_RELEASE 0

Since NODE_VERSION_IS_RELEASE is still set to 0 in the tarball, compiling the source results in the version output from node to be v0.6.21-pre.

I have not checked any of the other releases in http://nodejs.org/dist/v0.6.21/ as I only use the node from source.

isaacs commented Aug 4, 2012

Ah, yes, I'd added some things to the Makefile to prevent that from ever happening in v0.8. I got used to not having to check that, and didn't back port the fixes. The same version is reported in the binaries.

Backported the build guards to v0.6 branch on 7e6dea4, c527366 and 2a1f022.

Since that's the only problem in the release, and is purely cosmetic, let's just leave this as a known issue and have it fixed in 0.6.22, if and when that happens.

@isaacs isaacs closed this Aug 4, 2012

Member

dougwilson commented Sep 28, 2014

This never getting fixed makes me a sad panda :(

Member

rlidwka commented Sep 28, 2014

Does it really matter? I mean, only people who are actively using node 0.6 right now are those who port libraries to it thinking that people still use it.

Member

dougwilson commented Sep 28, 2014

So I only commented here because I just had to deal with this this weekend :) A customer who has a bunch of Node.js file processing moved from Linux servers to Windows servers and the 0.6.21 was custom compiled to fix this issue, and I had to figure out how to custom compile on Windows since the most recent 0.6 release is still the 0.6.21-pre release. I originally reported this issue from working with that very same customer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment