emit 'end' on http response objects #3855

Closed
isaacs opened this Issue Aug 11, 2012 · 4 comments

Comments

Projects
None yet
3 participants

isaacs commented Aug 11, 2012

  1. Rename the 'finish' event to 'end'.
  2. Document it. Add tests for it.
  3. Make @mikefrey's hard work completely pointless. (re: http://npm.im/response-end)

It will be done.

On Saturday, August 11, 2012, Isaac Z. Schlueter wrote:

  1. Change the 'finish' event to 'end'.

  2. Document it.

  3. Make @mikefrey https://github.com/mikefrey's hard work completely
    pointless. (re: )


    Reply to this email directly or view it on GitHubhttps://github.com/joyent/node/issues/3855.

Owner

bnoordhuis commented Aug 11, 2012

For the record, this gets a '+1 I concur' from me.

bnoordhuis closed this in 790d651 Sep 4, 2012

Owner

bnoordhuis commented Sep 4, 2012

Provisionally changed in 790d651. Criticism welcome but this at least gets it started.

isaacs commented Oct 4, 2012

Actually, this is not good. We can't have writable streams emitting 'end', because then either duplexes are unworkable, or we have to have completely weird exceptions all over the place and can't make all Writables match a consistent API.

The work going on in streams2 will bless the 'finish' event for all Writable streams, which is a bit of a weird event name, but meh. It's what tradition has given us, so let's roll with it.

Reverted on 836a06f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment