This repository has been archived by the owner. It is now read-only.

uv-darwin.h is missing in 0.9.1 #4062

Closed
luciferlu opened this Issue Sep 28, 2012 · 5 comments

Comments

Projects
None yet
3 participants
@luciferlu

uv-darwin.h under /deps/uv/include/uv-private folder is separated from uv-unix.h, but it isn't packed into binary package for Mac.

@bnoordhuis

This comment has been minimized.

Show comment Hide comment
@bnoordhuis

bnoordhuis Sep 28, 2012

Member

binary package === pkg installer? It's not supposed to install any header files. If it does, that's a bug - everything is supposed to go through node-gyp.

Member

bnoordhuis commented Sep 28, 2012

binary package === pkg installer? It's not supposed to install any header files. If it does, that's a bug - everything is supposed to go through node-gyp.

@luciferlu

This comment has been minimized.

Show comment Hide comment
@luciferlu

luciferlu Sep 29, 2012

Sorry, It's my mistake. I just realize my node environment is installed by n. Seems this is a issue of n instead of node. Please close this issue.

Sorry, It's my mistake. I just realize my node environment is installed by n. Seems this is a issue of n instead of node. Please close this issue.

@luciferlu luciferlu closed this Sep 29, 2012

@TooTallNate

This comment has been minimized.

Show comment Hide comment
@TooTallNate

TooTallNate Sep 29, 2012

@luciferlu The header files were removed from the make install step because presumably they were only useful for building native addons for node, and only for node-waf. Now that node-waf has been removed, and node-gyp is the replacement (which doesn't use those installed headers), there's no need to install them anymore.

It's not a node or n bug, but if you are using a native addon that still depends on node-waf, you should encourage the author to migrate to node-gyp.

@luciferlu The header files were removed from the make install step because presumably they were only useful for building native addons for node, and only for node-waf. Now that node-waf has been removed, and node-gyp is the replacement (which doesn't use those installed headers), there's no need to install them anymore.

It's not a node or n bug, but if you are using a native addon that still depends on node-waf, you should encourage the author to migrate to node-gyp.

@luciferlu

This comment has been minimized.

Show comment Hide comment
@luciferlu

luciferlu Sep 29, 2012

@TooTallNate Thanks for your information. You are right. The error is thrown when I install node-expat, which need build native part using node-waf. I have switched to node 0.8.x, and it works well now. Thanks again.

@TooTallNate Thanks for your information. You are right. The error is thrown when I install node-expat, which need build native part using node-waf. I have switched to node 0.8.x, and it works well now. Thanks again.

@TooTallNate

This comment has been minimized.

Show comment Hide comment
@TooTallNate

TooTallNate Sep 29, 2012

You're welcome :)

Also note that node-expat v1.6.1 supports building through node-gyp.

On Fri, Sep 28, 2012 at 8:33 PM, Yuntao Lu notifications@github.com wrote:

@TooTallNate https://github.com/TooTallNate Thanks for your
information. You are right. The error is thrown when I install node-expat,
which need build native part using node-waf. I have switched to node 0.8.x,
and it works well now. Thanks again.


Reply to this email directly or view it on GitHubhttps://github.com/joyent/node/issues/4062#issuecomment-9000491.

You're welcome :)

Also note that node-expat v1.6.1 supports building through node-gyp.

On Fri, Sep 28, 2012 at 8:33 PM, Yuntao Lu notifications@github.com wrote:

@TooTallNate https://github.com/TooTallNate Thanks for your
information. You are right. The error is thrown when I install node-expat,
which need build native part using node-waf. I have switched to node 0.8.x,
and it works well now. Thanks again.


Reply to this email directly or view it on GitHubhttps://github.com/joyent/node/issues/4062#issuecomment-9000491.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.