Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Crash on XP (Perf Counters) #4462
I am building from the master branch on an xp sp3 machine w/ vs2010. It looks like recently there was support added for the windows perf counters (InitPerfCountersWin32). However, it looks like functions such as PerfStartProviderEx are only available since Vista. There is a runtime check for advapi32.dll, but not for the individual GetProcAddress calls. Easiest solution would just be to add a NULL check on the dynamic function lookups.
I could write a patch, but basically:
if (!perfctr_startProvider) return;