don't first convert to Buffer if setEncoding is used #5581

Closed
trevnorris opened this Issue May 28, 2013 · 2 comments

Projects

None yet

1 participant

stream_wrap automatically converts all incoming data to a Buffer after which it's passed to MakeCallback. This is an unfortunate step since the Buffer will never be used. So instead need a way to allow data manipulation to occur before it's been sent to the MakeCallback.

I've done some preliminary work on a completely generic solution that goes along with my Buffer and no SlabAllocator changes: trevnorris/node@af33baa

Though we may need a more generic solution than just for stream_wrap.

@trevnorris trevnorris was assigned May 28, 2013

Moving this to v1.0 milestone. This is not going to affect the end user's functionality, which are the changes we're wanting to get in before the v0.12 release.

Not going to bother with this.

@trevnorris trevnorris closed this Apr 2, 2014
@smanders smanders pushed a commit to smanders/node-v0.x-archive that referenced this issue Apr 7, 2016
@evanlucas evanlucas 2016-03-31 Version 5.10.0 (Stable) Release
Notable changes:

* buffer:
  * make byteLength work with ArrayBuffer & DataView (Jackson Tian)
[#5255](nodejs/node#5255)
  * backport --zero-fill-buffers command line option (James M Snell)
[#5744](nodejs/node#5744)
  * backport new buffer constructor APIs (James M Snell)
[#5763](nodejs/node#5763)
  * add swap16() and swap32() methods (James M Snell)
[#5724](nodejs/node#5724)
* fs: add the fs.mkdtemp() function. (Florian MARGAINE)
[#5333](nodejs/node#5333)
* net: emit host in lookup event (HUANG Wei)
[#5598](nodejs/node#5598)
* node: --no-browser-globals configure flag (Fedor Indutny)
[#5853](nodejs/node#5853)
* npm: Upgrade to v3.8.3. Fixes a security flaw in the use of
authentication tokens in HTTP requests that would allow an attacker to
set up a server that could collect tokens from users of the command-line
interface. Authentication tokens have previously been sent with every
request made by the CLI for logged-in users, regardless of the destination
of the request. This update fixes this by only including those tokens
for requests made against the registry or registries used for the
current install. (Forrest L Norvell)
[npm/node#6](npm/node#6)
* repl: support standalone blocks (Prince J Wesley)
[#5581](nodejs/node#5581)
* src: override v8 thread defaults using cli options (Tom Gallacher)
[#4344](nodejs/node#4344)

PR-URL: nodejs/node#5970
64c87e2
@smanders smanders pushed a commit to smanders/node-v0.x-archive that referenced this issue Apr 8, 2016
@evanlucas evanlucas 2016-03-31 Version 5.10.0 (Stable) Release
Notable changes:

* buffer:
  * make byteLength work with ArrayBuffer & DataView (Jackson Tian)
[#5255](nodejs/node#5255)
  * backport --zero-fill-buffers command line option (James M Snell)
[#5744](nodejs/node#5744)
  * backport new buffer constructor APIs (James M Snell)
[#5763](nodejs/node#5763)
  * add swap16() and swap32() methods (James M Snell)
[#5724](nodejs/node#5724)
* fs: add the fs.mkdtemp() function. (Florian MARGAINE)
[#5333](nodejs/node#5333)
* net: emit host in lookup event (HUANG Wei)
[#5598](nodejs/node#5598)
* node: --no-browser-globals configure flag (Fedor Indutny)
[#5853](nodejs/node#5853)
* npm: Upgrade to v3.8.3. Fixes a security flaw in the use of
authentication tokens in HTTP requests that would allow an attacker to
set up a server that could collect tokens from users of the command-line
interface. Authentication tokens have previously been sent with every
request made by the CLI for logged-in users, regardless of the destination
of the request. This update fixes this by only including those tokens
for requests made against the registry or registries used for the
current install. (Forrest L Norvell)
[npm/node#6](npm/node#6)
* repl: support standalone blocks (Prince J Wesley)
[#5581](nodejs/node#5581)
* src: override v8 thread defaults using cli options (Tom Gallacher)
[#4344](nodejs/node#4344)
79ea8c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment