This repository has been archived by the owner. It is now read-only.

All code in src/ should pass tools/cpplint.py #591

Closed
ry opened this Issue Jan 28, 2011 · 4 comments

Comments

Projects
None yet
5 participants

ry commented Jan 28, 2011

including these warnings:

src/node_net.cc:71: Do not use namespace using-directives. Use using-declarations instead. [build/namespaces] [5]

Hi,
This is my first time participating in the project. While getting familiar with the code base, I could look at some lint warnings/errors. Do you have any priorities for types of warnings/errors?

Btw, Node.js is looking AMAZING! :) Cheers for that

sh1mmer commented Oct 20, 2011

The current results of make cpplint

https://gist.github.com/1302169

Note this doesn't seem to lint anything but /src, so libuv has not been included.

I think this was worked out for 0.9, could you confirm @tjfontaine please?

Owner

indutny commented Dec 24, 2013

@diasdavid yep, it does now.

@indutny indutny closed this Dec 24, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.