Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

crypto: do not return after throw #6912

Closed
indutny opened this issue Jan 19, 2014 · 0 comments
Closed

crypto: do not return after throw #6912

indutny opened this issue Jan 19, 2014 · 0 comments
Assignees
Milestone

Comments

@indutny
Copy link
Member

indutny commented Jan 19, 2014

Do not call args.GetReturnValue().Set(..) after ThrowException, breaks everything!

@ghost ghost assigned indutny Jan 19, 2014
indutny added a commit to indutny/node that referenced this issue Jan 19, 2014
Do not throw in internal C++ methods, that clobbers logic and may lead
to the situations, where both exception was thrown and the value was
returned (via `args.GetReturnValue().Set()`). That doesn't play nicely
with v8.

fix nodejs#6912
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant