a mistype in the bundled v8 #7020

Closed
Chilledheart opened this Issue Feb 1, 2014 · 8 comments

5 participants

@Chilledheart

When hacking with node, i got a build error (built on freebsd)

../deps/v9/src/platform-freebsd.cc:185:62: error: too few arguments provided to function-like macro invocation
    LOG(isolate SharedLibraryEvent(start_of_path, start, end));
                                                             ^
../deps/v8/src/log.h:86:9: note: macro 'LOG' defined here
#define LOG(isolate, Call)                          \
        ^
../deps/v8/src/platform-freebsd.cc:185:5: error: use of undeclared identifier 'LOG'
    LOG(isolate SharedLibraryEvent(start_of_path, start, end));
    ^
2 errors generated.
gmake[1]: *** [/usr/home/bsd/node/out/Release/obj.target/v8_base.x64/deps/v8/src/platform-freebsd.o] Error 1
gmake[1]: *** Waiting for unfinished jobs....
gmake[1]: Leaving directory `/usr/home/bsd/node/out'
gmake: *** [node] Error 2

It's obvious a mistype in deps/v8/src/platform-freebsd.cc, at LINE 186:

LOG(isolate SharedLibraryEvent(start_of_path, start, end));

which should be something like:

LOG(isolate, SharedLibraryEvent(start_of_path, start, end));

A comma is missing here :-P.

related issue in v8, which is fixed in r18035.

If there is any plan to backport the patch, I really appreciate it.

@Chilledheart

the patch I use is available here Chilledheart/node@5443a9e, if anyone interested in it

@vkurchatkin
Node.js Foundation member

It looks like that has been fixed in de8c0a5 but then was broken again in 8803aa3.

@Chilledheart

yeah, 8803aa3 is a backported patch with a 3.22.x v8 while the upstream fix is available in a 3.23.x v8 r18035.

I encountered that error when trying to build node with dtrace on freebsd. visit Chilledheart/node@e200309 for more

@Chilledheart

I meant that backported patch for v8 might have been reverted.

@trevnorris
@tjfontaine

I will take care of this shortly, I am just cleaning up the freebsd build slave mechanism so I don't lose it again

@tjfontaine tjfontaine was assigned by indutny Feb 3, 2014
@indutny
Node.js Foundation member

@tjfontaine assigning to you

@tjfontaine tjfontaine added a commit that closed this issue Feb 16, 2014
@bnoordhuis bnoordhuis v8: unbreak freebsd build
reland de8c0a5

Fixes #7020 and #7021
3421d29
@Chilledheart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment