Script.runIn__Context functions leak on error #704

Closed
laverdet opened this Issue Feb 20, 2011 · 1 comment

Comments

Projects
None yet
2 participants

In node_script.cc there's cleanup code at the bottom of EvalMachine, however there's 5 early returns which all lead to memory leaks and dangling contexts.

Run this and watch node's memory usage climb.

for (;;) {
  try {
    process.binding('evals').Script.runInNewContext('throw 1;');
  } catch(e) {}
}

ry commented Feb 24, 2011

Fix memleak in vm.runInNewContext

Closed by 1f50d71.

@coolaj86 coolaj86 pushed a commit that referenced this issue Apr 15, 2011

@ry ry Fix memleak in vm.runInNewContext
Closes GH-704.
1f50d71

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment