Skip to content
This repository has been archived by the owner. It is now read-only.

2147483647 > -2147483648 is false #7528

Closed
gzm0 opened this issue Apr 29, 2014 · 8 comments

Comments

Projects
None yet
4 participants
@gzm0
Copy link

commented Apr 29, 2014

How to reproduce:

$ node
> 2147483647 > -2147483648
false

Expected result: true

Note that when inverting the arguments, the result is correct:

 > -2147483648 < 2147483647
true

Node version: v0.10.26, MacOS X 10.7.5

@indutny

This comment has been minimized.

Copy link
Member

commented Apr 29, 2014

Hello!

Thanks for letting us know, unfortunately it isn't a node.js problem, but is rather a v8 problem. It seems to be fixed in the recents versions, but not in one that node.js v0.10 is bundling.

May I ask you to submit it here https://code.google.com/p/v8/issues/list ?

I'll try to find the commit that would fix it...

@gzm0

This comment has been minimized.

Copy link
Author

commented May 2, 2014

Sorry for following up so late. How can I find the v8 version a given Node.js version is compiled against?

@fivdi

This comment has been minimized.

Copy link

commented May 2, 2014

$ node
> process.versions.v8
'3.14.5.9'
@gzm0

This comment has been minimized.

Copy link
Author

commented May 2, 2014

@gzm0

This comment has been minimized.

Copy link
Author

commented May 2, 2014

v8 says its fixed in newer versions. So I guess we're stuck waiting until you guys bundle 0.11.x?

@gabeio

This comment has been minimized.

Copy link

commented May 2, 2014

@gzm0 0.11.* is developmental versions and are already being bundled 0.12.* is going to be the next stable bundled version of node (after 0.10.). Looking http://blog.nodejs.org/ will give you an idea usually 0.[even]. are stable, 0.[odd].* are unstable/development versions. https://github.com/joyent/node/wiki/FAQ explains versions better.

@indutny

This comment has been minimized.

Copy link
Member

commented May 2, 2014

I tried using 3.14.5.10, but unfortunately the bug is still present in it.

indutny added a commit that referenced this issue May 2, 2014

deps: backport 23f2736a from v8 upstream
Original text:

    Fix corner case in x64 compare stubs.

    BUG=v8:2416

    Review URL: https://codereview.chromium.org/11413087

fix #7528
@indutny

This comment has been minimized.

Copy link
Member

commented May 2, 2014

Should be fixed by a960d17, will be released in next v0.10 . Thank you!

@indutny indutny closed this May 2, 2014

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.