Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Faulty browser url encoding emulation for slash flipping #8458

Closed
eborden opened this issue Sep 26, 2014 · 0 comments
Closed

Faulty browser url encoding emulation for slash flipping #8458

eborden opened this issue Sep 26, 2014 · 0 comments
Labels
S-confirmed-bug url

Comments

@eborden
Copy link

eborden commented Sep 26, 2014

On line 116 in lib/url.js slash flipping occurs in the entire url excluding the hash. Proper browser emulation would include the query string in flip exclusion.

http://www.foo.com/foo\bar\?spla\t#fu\nk

should be translated to

http://www.foo.com/foo/bar/?spla%5Ct#fu%5Cnk

pull request to follow.
eborden pushed a commit to eborden/node that referenced this issue Sep 26, 2014
fixed url encoding for slash switching emulation.
ddd4eed 
Fixes nodejs#8458
@eborden eborden mentioned this issue Sep 26, 2014
Closed
@eborden eborden changed the title Faulty browser url encoding emulattion for slash flipping Faulty browser url encoding emulation for slash flipping Sep 26, 2014
eborden pushed a commit to eborden/node that referenced this issue Sep 29, 2014
Handle ? in hash case.
2f7bd2f 
Fixes nodejs#8458
chrisdickinson pushed a commit that referenced this issue Oct 7, 2014
@chrisdickinson
url: fixed encoding for slash switching emulation.
640ad63 
Fixes: #8458
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Chris Dickinson <christopher.s.dickinson@gmail.com>
petkaantonov added a commit to petkaantonov/urlparser that referenced this issue Jan 8, 2015
@petkaantonov
Port fix to nodejs/node-v0.x-archive#8458
8a0bd4e
@GUI GUI mentioned this issue Mar 9, 2015
Closed
@GUI GUI mentioned this issue Nov 12, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
S-confirmed-bug url
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisdickinson @eborden