This repository was archived by the owner on Apr 22, 2023. It is now read-only.
node::DecodeBytes calls toString with no encoding if we have a Buffer #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uffer so we use the correct slice method.
|
For the record, this still merges cleanly and tests all pass... Anything we can do to get this landed? |
|
@ry is this something that we can land in master? |
|
Closing, no longer relevant. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node::DecodeBytesshould pass the encoding totoStringif we have a buffer so we use the correctslicemethod. There are some more detailed comments on the commit in this pull request that explain the issue in more detail.