Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix: Debugger Interface Command Issue - RegEx #1144

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

When the debugger interface handles commands, (_debugger.js), in function handleCommand(), it uses regex which accepts incorrect input. For example: (line 946/master)

}else if (/^step/.test(cmd) || /^s/.test(cmd)){

This incorrectly returns true if 'seige' or 'sigh' are input, because they begin with s, resulting in confusing debugger behaviour.

Changes:

}else if (/^s(tep)?$/.test(cmd)){

Should return the correct response for both 's' and 'step'.

Siddharth Mahendraker added some commits Jun 2, 2011

Fixed several RegEx issues in _debugger.js which allowed users to inp…
…ut non-valid commands, resulting in confusing behaviour.
Fixed several RegEx issues in _debugger.js which allowed users to inp…
…ut non-valid commands, resulting in confusing behaviour.

@ry ry closed this in 37d529f Jun 3, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment