Skip to content

fix an broken question #1274

Closed
wants to merge 1 commit into from

2 participants

@xenyou
xenyou commented Jul 5, 2011

I found a bug about user interface in yesNoQuestion method in _debugger.js.

When you run "#node debug some.js" in command line and do the following steps,
you will experience an weird semantics.

  1. debug> run
  2. stop at some breakpoint
  3. press Ctrl+c to exit some.js
  4. you will be asked that "A debugging session is active. Quit anyway? (y or n)"
  5. press a key that NOT y or n. (e.g. press 'l')
  6. this time, you will be asked that "The program being debugged has been started already. Start it from the beginning? (y or n)"
  7. press y
  8. the node process will be aborted.

It's weird. Do you think so?
I think if we type a non-y/n answer, the question shoud be repeated.
For example, like this,

debug>
A debugging session is active. Quit anyway? (y or n) l
Please answer y or n.

A debugging session is active. Quit anyway? (y or n) l
Please answer y or n.

A debugging session is active. Quit anyway? (y or n)

So, I've fixed this to repeat the question. Please check it.

@koichik
koichik commented Jul 5, 2011

LGTM. May I merge it into v0.4 rather than master?

@xenyou xenyou closed this Jul 5, 2011
@xenyou
xenyou commented Jul 5, 2011

Sure. Please go ahead.
Thanks.

@xenyou xenyou reopened this Jul 5, 2011
@koichik koichik added a commit that closed this pull request Jul 6, 2011
@xenyou xenyou fix an broken question.
Fixes #1274.
82cfdb8
@koichik koichik closed this in 82cfdb8 Jul 6, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.