Stream.pipe(destinationStream) should return destinationStream #1303

wants to merge 3 commits into


None yet

5 participants

felixge commented Jul 11, 2011

LGTM. +1. Not sure if 0.4 or master so.

tj commented Jul 11, 2011

yes please!

slaskis commented Jul 13, 2011

Simple, yet brilliant

@isaacs isaacs added a commit that closed this pull request Jul 14, 2011
@tmpvar @isaacs tmpvar + isaacs Close #1303 Stream.pipe returns the destination

* Simple change to make Stream.pipe(destination) return the destination Stream
* Test: ensure Stream.pipe(destination) returns the destination Stream
* updated Stream.pipe() documentation to reflect that it now returns the
  destination stream
@isaacs isaacs closed this in b722aaa Jul 14, 2011
isaacs commented Jul 14, 2011

Pushed into master. Thanks, @tmpvar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment