added additional properties to getPeerCertificate with test case #1612

Closed
wants to merge 2 commits into from

3 participants

@niclashoyer

Added additional properties to getPeerCertificate, now includes
subjectAltName, Exponent and Modulus (FOAF+SSL friendly).

Patch written by Nathan,
http://groups.google.com/group/nodejs/browse_thread/thread/1d42da4cb2e51536

I also added a test case based on test-https-simple to test the new attributes.

@koichik

@niclashoyer - Thanks! This time, can you sign the CLA? :)
And can I modify the patch?

  1. Apply @pquerna's suggestion.
  2. Fix BIOs usage.
@niclashoyer

just signed it.

Of course, please modify the patch :)

@bnoordhuis
Node.js Foundation member

Use NID_subject_alt_name: da3bc23

However, valgrind is complaining wildly on the test/simple/test-https-foafssl.js test (with and without da3bc23). Needs further investigating.

@koichik

Fix BIO's usage: 937dc27

@koichik

@bnoordhuis - With 937dc27, valgrind isn't complaining.

before:

==8852== ERROR SUMMARY: 4 errors from 4 contexts (suppressed: 4 from 4)

after:

==8931== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 4 from 4)

Can I merge all together?

@bnoordhuis
Node.js Foundation member

@koichik: yes, go ahead.

@koichik koichik added a commit that closed this pull request Sep 2, 2011
@koichik koichik crypto: Fix BIO's usage.
Fixes #1612.
Fixes #1296.
28a9084
@koichik koichik closed this in 28a9084 Sep 2, 2011
@koichik

@niclashoyer - Thanks for your contribution!

@skomski skomski added a commit that referenced this pull request Sep 4, 2011
@koichik koichik crypto: Fix BIO's usage.
Fixes #1612.
Fixes #1296.
7b1a104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment