adding a signal of support on win32. #1796

Closed
wants to merge 4 commits into
from

Projects

None yet

7 participants

@runner-mei

I am a developer on the win32 platform, I found libuv do not support signal, so adding a signal of support on win32, I hope it helps you.

@Hello71
Hello71 commented Sep 30, 2011

What's with the �s?

@runner-mei

I'm sorry. It is chinese, I'm come from chinese.

@KenanSulayman

Please remove the chinese characters off the commit.

@bnoordhuis
Member

@piscisaureus or @igorzi: Can one of you review this patch? I assume that at the very least the linked list should be replaced with a ngx_queue_t?

@piscisaureus
Member

@runner-mei

I'd like to have this in libuv. Can I ask you to do the following:

  • make a patch that applies to libuv and rebase it (try git format-patch --relative=deps/uv to get a patch file that you can apply).
  • change the linked list to use ngx_queue_t (see ngx_queue.h).
  • Use consistent indentations and replace all tabs by 2 spaces.
@runner-mei

I am happy to do it, I need to submit the patch to libuv?

@runner-mei

I have send a pull request to joyent/libuv.

On the node part of the patch, I need to add some test

@Nodejs-Jenkins

Can one of the admins verify this patch?

@tjfontaine

Thanks, most of this work was done in 600a646 and in libuv.

@tjfontaine tjfontaine closed this Feb 18, 2014
@wiedi wiedi pushed a commit to wiedi/node that referenced this pull request Aug 15, 2015
@rvagg rvagg 2015-08-04 io.js v3.0.0 Release
Notable changes:

* buffer:
  - Due to changes in V8, it has been necessary to reimplement Buffer
    on top of V8's Uint8Array. While every effort has been made to
    maintain performance, users are likely to experience a different
    performance profile depending on how Buffer is used.
    (Trevor Norris) #1825.
  - Buffer can now take ArrayBuffers as a constructor argument
    (Trevor Norris) #2002.
  - When a single buffer is passed to Buffer.concat(), a new, copied
    Buffer object will be returned; previous behavior was to return
    the original Buffer object (Sakthipriyan Vairamani) #1937.
* build: PPC support has been added to core to allow compiling on
  pLinux BE and LE (AIX support coming soon) (Michael Dawson) #2124.
* dgram: If an error occurs within socket.send() and a callback has
  been provided, the error is only passed as the first argument to the
  callback and not emitted on the socket object; previous behavior was
  to do both (Matteo Collina & Chris Dickinson) #1796
* freelist: Deprecate the undocumented freelist core module
  (Sakthipriyan Vairamani) #2176.
* http:
  - Status codes now all use the official IANA names as per RFC7231,
    e.g. http.STATUS_CODES[414] now returns 'URI Too Long' rather than
    'Request-URI Too Large' (jomo) #1470.
  - Calling .getName() on an HTTP agent no longer returns a trailing
    colon, HTTPS agents will no longer return an extra colon near the
    middle of the string (Brendan Ashworth) #1617.
* node:
  - NODE_MODULE_VERSION has been bumped to 45 to reflect the break in
    ABI (Rod Vagg) #2096.
  - Introduce a new process.release object that contains a name
    property set to 'io.js' and sourceUrl, headersUrl and libUrl
    (Windows only) properties containing URLs for the relevant
    resources; this is intended to be used by node-gyp
    (Rod Vagg) #2154.
  - The version of node-gyp bundled with io.js now downloads and uses
    a tarball of header files from iojs.org rather than the full
    source for compiling native add-ons; it is hoped this is a
    temporary floating patch and the change will be upstreamed to
    node-gyp soon (Rod Vagg) #2066.
* repl: Persistent history is now enabled by default. The history file
  is located at ~/.node_repl_history, which can be overridden by the
  new environment variable NODE_REPL_HISTORY. This deprecates the
  previous NODE_REPL_HISTORY_FILE variable. Additionally, the format
  of the file has been changed to plain text to better handle file
  corruption. (Jeremiah Senkpiel) #2224.
* smalloc: The smalloc module has been removed as it is no longer
  possible to provide the API due to changes in V8
  (Ben Noordhuis) #2022.
* tls: Add server.getTicketKeys() and server.setTicketKeys() methods
  for TLS session key rotation (Fedor Indutny) #2227.
* v8: Upgraded to 4.4.63.26
  - ES6: Enabled computed property names
  - ES6: Array can now be subclassed in strict mode
  - ES6: Implement rest parameters in staging, use the
    --harmony-rest-parameters command line flag
  - ES6: Implement the spread operator in staging, use the
    --harmony-spreadcalls command line flag
  - Removed SetIndexedPropertiesToExternalArrayData and related APIs,
    forcing a shift to Buffer to be reimplemented based on Uint8Array
  - Introduction of Maybe and MaybeLocal C++ API for objects which may
    or may not have a value.
  - Added support for PPC

PR-URL: nodejs/node#2299
6faf17c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment