Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Change formatProperty in util.js to use Object.getOwnPropertyDescriptor ... #2109
It's a particular issue with the four deprecated accessor functions because they make an end-run around all the new Object.* stuff introduced in ES5. If there's anything else that's not at least ES5-normal then it should be updated because most of it will be disallowed in ES6-strict or at least its interaction with new things in ES6 will be 'undefined'. The spec is a couple years from final completion but much of it is well defined and implemented in both V8 and SpiderMonkey already.
I'll start going through the libs with this task in mind. The specific issue in this pull request is by far the biggest as it causes anything
I'm currently working around it by monkey-patching the four functions prior to using Proxies which works.
@Benvie - Sorry for the delay. LGTM, merging.
However, if the object has no prototype, current
After this patch is applied: