OutgoingMessage.prototype.write does not take Array #2208

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

seebees commented Nov 27, 2011

Changed the type checking for OutgoingMessage.prototype.write so it only accepts string and Buffer.

And test.
Fixes #2162

I tested this agains v0.6 but I can not build master right now. I can rebase and test again if you like once that works, but it seems small.

@seebees seebees OutgoingMessage.prototype.write does not take Array
Changed the type checking for OutgoingMessage.prototype.write so it only accepts string and Buffer.

And test.
Fixes #2162
451f8ef

seebees commented Nov 29, 2011

@koichik sorry, I updated the issue, not the pull.

koichik closed this in aab958b Nov 29, 2011

koichik commented Nov 29, 2011

@seebees: Thanks!

@alexkwolfe alexkwolfe added a commit to alexkwolfe/node that referenced this pull request Dec 23, 2011

@seebees @alexkwolfe seebees + alexkwolfe OutgoingMessage.prototype.write does not take Array
Changed the type checking for OutgoingMessage.prototype.write so it only accepts string and Buffer.

And test.
Fixes #2162
Fixes #2208
5d7808e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment