Tell the user why the HTTP response should not have a body. #2260

Closed
wants to merge 1 commit into from

4 participants

@partheseas

No description provided.

@isaacs

Is this error output really even necessary? It seems like node could just ignore the body silently.

@bnoordhuis
Node.js Foundation member

And get all kinds of confused bug reports? I'd rather keep it, it's a useful warning while developing.

@bnoordhuis bnoordhuis commented on the diff Dec 5, 2011
lib/http.js
@@ -773,7 +773,10 @@ OutgoingMessage.prototype._flush = function() {
function ServerResponse(req) {
OutgoingMessage.call(this);
- if (req.method === 'HEAD') this._hasBody = false;
+ if (req.method === 'HEAD') {
+ this._hasBody = false;
+ this._noBodyReason = "HEAD";
@bnoordhuis
Node.js Foundation member

I would strongly prefer it if you don't add another property to the ServerResponse class. It's never used in a well-debugged application so it only adds overhead.

It just seemed like the best way to do it. There are already so many I didn't think one more would be a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@partheseas

If the error was removed, then a lot of people would probably submit issues of node not writing to the HTTP stream when told to.

@Nodejs-Jenkins

Can one of the admins verify this patch?

@isaacs

This no longer warns to stderr, and this pull is super old and crusty. Closing. Thanks for playing, please play again soon :)

@isaacs isaacs closed this Jun 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment