make install? #2331

Closed
wants to merge 5 commits into from

3 participants

@indutny
Node.js Foundation member

nt

@bnoordhuis bnoordhuis commented on an outdated diff Dec 14, 2011
@@ -10,7 +17,24 @@ out/Release/node: all
out/Makefile: common.gypi deps/uv/uv.gyp deps/http_parser/http_parser.gyp deps/zlib/zlib.gyp deps/v8/build/common.gypi deps/v8/tools/gyp/v8.gyp node.gyp options.gypi
tools/gyp_node -f make
-install uninstall:
+install: all install-bin install-includes
+
+install-includes:
+ $(call INSTALL,$(INCLUDE_DIR),src/node.h)
+ $(call INSTALL,$(INCLUDE_DIR),src/node_buffer.h)
+ $(call INSTALL,$(INCLUDE_DIR),src/node_object_wrap.h)
+ $(call INSTALL,$(INCLUDE_DIR),src/node_version.h)
+ $(call INSTALL,$(INCLUDE_DIR),deps/v8/include/*.h)
+ $(call INSTALL,$(INCLUDE_DIR),deps/uv/include/*.h)
+ $(call INSTALL,$(INCLUDE_DIR)/uv-private,deps/uv/include/uv-private/*.h)
+ $(call INSTALL,$(INCLUDE_DIR)/c-ares,deps/uv/include/ares.h)
+ $(call INSTALL,$(INCLUDE_DIR)/c-ares,deps/uv/include/ares_version.h)
+
+install-bin:
@bnoordhuis
Node.js Foundation member

Can you split this into two targets, install-node and install-npm? install-npm should not run if --without-npm is passed to ./configure, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@bnoordhuis bnoordhuis and 2 others commented on an outdated diff Dec 14, 2011
tools/gyp_node
@@ -1,6 +1,7 @@
#!/usr/bin/env python
import glob
import os
+import json
@bnoordhuis
Node.js Foundation member

json is a python 2.6 module and we try to be compatible with 2.5.

@indutny
Node.js Foundation member
indutny added a note Dec 14, 2011

but you are using it in configure ;)

@bnoordhuis
Node.js Foundation member

Right you are, leave it in.

@ry
ry added a note Dec 14, 2011

we should probably rip out json.py from python and put it into the node tree so that we can be compatibile with 2.5. and or manually write out json from configure

@indutny
Node.js Foundation member
indutny added a note Dec 14, 2011

yeah, but note that I removed that line ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@indutny
Node.js Foundation member

@bnoordhuis Question: this file can be run only by invoking : "make install", right? If so, why should I care about using commands like rm -rf, cp -rf and slashes, and etc. Can we assume that platform supports this utilities if it has make?

@bnoordhuis
Node.js Foundation member

Can we assume that platform supports this utilities if it has make?

Not on Windows. For example, I have a mingw32 install that comes bundled with make but not coreutils.

@indutny
Node.js Foundation member

Oh...

@indutny indutny [make] remove all windows hacks
* use /usr/local as default prefix
* less wildcards
2223f07
@ry ry added a commit that closed this pull request Dec 14, 2011
@indutny indutny Implement make install
Fixes #2331, #2197, #2283
be23c51
@ry ry closed this in be23c51 Dec 14, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment