punycode: Update to v0.3.0 #2456

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@mathiasbynens

The Punycode.js v0.3.0 package features more extensive unit and performance test coverage.

As for the code itself, the only change between v0.2.1 and v0.3.0 is a minor API change. The utf16 object has been renamed to ucs2 which is more accurate. The main exposed methods (toASCII, toUnicode, encode, decode) are unaffected.

Even though no functionality is added it seems like a good idea to keep Node’s punycode.js in sync with the main repo.

@AndreasMadsen
Member

While you guys merge this, then please make the jslinter ignore this!

@bnoordhuis
Member

While you guys merge this, then please make the jslinter ignore this!

How so, Andreas?

@AndreasMadsen
Member

@bnoordhuis

make jslint should ignore this file:
bestiejs/punycode.js#6

@mmalecki mmalecki added a commit to mmalecki/node that referenced this pull request Jan 10, 2012
@mmalecki mmalecki makefile: ignore `lib/punycode.js` while linting
`punycode` is a third party code which generates a lot of lint errors.
Upstream was contacted in order to fix it in bestiejs/punycode.js#6, but
request was denied.

Therefore, it's reasonable to exclude this file from linting process.

Ref #2456.
04c2a6f
@bnoordhuis bnoordhuis added a commit that referenced this pull request Jan 11, 2012
@mmalecki @bnoordhuis mmalecki + bnoordhuis makefile: ignore `lib/punycode.js` while linting
`punycode` is a third party code which generates a lot of lint errors.
Upstream was contacted in order to fix it in bestiejs/punycode.js#6, but
request was denied.

Therefore, it's reasonable to exclude this file from linting process.

Ref #2456.
b073989
@bnoordhuis
Member

@mathiasbynens: Thanks, landed in master in 8abb73e.

@mmalecki: Thanks, landed in v0.6 in b073989. Will get merged into master some time in the future.

@bnoordhuis bnoordhuis closed this Jan 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment