gyp_addon: Include the node.lib file at link time on Windows. #2480

Closed
wants to merge 1 commit into
from

2 participants

@TooTallNate

Makes the basic gyp_addon script work with Windows.

The "Debug" dir is currently hard-coded. A better way would be to use
the currently selected "configuration" that gyp is executing, but I could not
figure out how to get a variable of the configuration...

@TooTallNate TooTallNate Include the node.lib file at link time on Windows.
Makes the basic `gyp_addon` script work with Windows.

The "Debug" dir is currently hard-coded. A better way would be to use
the currently selected "configuration" that gyp is executing, but I could not
figure out how to get a variable of the configuration...
43212f4
@indutny indutny added a commit that closed this pull request Jan 16, 2012
@indutny indutny gyp: install node-gyp
* fixes #2480
3d1476a
@indutny indutny closed this in 3d1476a Jan 16, 2012
@joaocgreis joaocgreis pushed a commit to janeasystems/node-v0.x-archive that referenced this pull request Aug 27, 2015
@rvagg rvagg doc: update changelog for io.js v3.2.0
Notable changes:

* events: Added EventEmitter#listenerCount(event) as a replacement for
  EventEmitter.listenerCount(emitter, event), which has now been
  marked as deprecated in the docs. (Sakthipriyan Vairamani) #2349
* module: Fixed an error with preloaded modules when the current
  working directory doesn't exist. (Bradley Meck) #2353
* node: Startup time is now about 5% faster when not passing V8 flags.
  (Evan Lucas) #2483
* repl: Tab-completion now works better with arrays.
  (James M Snell) #2409
* string_bytes: Fixed an unaligned write in the handling of UCS2
  encoding. (Fedor Indutny) #2480
* tls: Added a new --tls-cipher-list flag that can be used to override
  the built-in default cipher list. (James M Snell) #2412

PR-URL: nodejs/node#2512
f9539c1
@richardlau richardlau pushed a commit to ibmruntimes/node that referenced this pull request Sep 18, 2015
@rvagg rvagg 2015-08-25 io.js v3.2.0 Release
Notable changes:

* events: Added EventEmitter#listenerCount(event) as a replacement for
  EventEmitter.listenerCount(emitter, event), which has now been
  marked as deprecated in the docs. (Sakthipriyan Vairamani) #2349
* module: Fixed an error with preloaded modules when the current
  working directory doesn't exist. (Bradley Meck) #2353
* node: Startup time is now about 5% faster when not passing V8 flags.
  (Evan Lucas) #2483
* repl: Tab-completion now works better with arrays.
  (James M Snell) #2409
* string_bytes: Fixed an unaligned write in the handling of UCS2
  encoding. (Fedor Indutny) #2480
* tls: Added a new --tls-cipher-list flag that can be used to override
  the built-in default cipher list. (James M Snell) #2412
2364553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment