Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

gyp_addon: Include the node.lib file at link time on Windows. #2480

Closed
wants to merge 1 commit into from

2 participants

@TooTallNate
Owner

Makes the basic gyp_addon script work with Windows.

The "Debug" dir is currently hard-coded. A better way would be to use
the currently selected "configuration" that gyp is executing, but I could not
figure out how to get a variable of the configuration...

@TooTallNate TooTallNate Include the node.lib file at link time on Windows.
Makes the basic `gyp_addon` script work with Windows.

The "Debug" dir is currently hard-coded. A better way would be to use
the currently selected "configuration" that gyp is executing, but I could not
figure out how to get a variable of the configuration...
43212f4
@indutny indutny closed this pull request from a commit
@indutny indutny gyp: install node-gyp
* fixes #2480
3d1476a
@indutny indutny closed this in 3d1476a
@joaocgreis joaocgreis referenced this pull request from a commit in janeasystems/node
@rvagg rvagg doc: update changelog for io.js v3.2.0
Notable changes:

* events: Added EventEmitter#listenerCount(event) as a replacement for
  EventEmitter.listenerCount(emitter, event), which has now been
  marked as deprecated in the docs. (Sakthipriyan Vairamani) #2349
* module: Fixed an error with preloaded modules when the current
  working directory doesn't exist. (Bradley Meck) #2353
* node: Startup time is now about 5% faster when not passing V8 flags.
  (Evan Lucas) #2483
* repl: Tab-completion now works better with arrays.
  (James M Snell) #2409
* string_bytes: Fixed an unaligned write in the handling of UCS2
  encoding. (Fedor Indutny) #2480
* tls: Added a new --tls-cipher-list flag that can be used to override
  the built-in default cipher list. (James M Snell) #2412

PR-URL: nodejs/node#2512
f9539c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 6, 2012
  1. @TooTallNate

    Include the node.lib file at link time on Windows.

    TooTallNate authored
    Makes the basic `gyp_addon` script work with Windows.
    
    The "Debug" dir is currently hard-coded. A better way would be to use
    the currently selected "configuration" that gyp is executing, but I could not
    figure out how to get a variable of the configuration...
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 0 deletions.
  1. +3 −0  tools/addon.gypi
  2. +1 −0  tools/gyp_addon
View
3  tools/addon.gypi
@@ -12,6 +12,9 @@
'conditions': [
[ 'OS=="mac"', {
'libraries': [ '-undefined dynamic_lookup' ],
+ }],
+ [ 'OS=="win"', {
+ 'libraries': [ '-l<(node_root_dir>/Debug/node.lib' ],
}]
]
}
View
1  tools/gyp_addon
@@ -16,6 +16,7 @@ if __name__ == '__main__':
args.extend(['-I', common_gypi])
args.extend(['-Dlibrary=shared_library'])
args.extend(['-Dvisibility=default'])
+ args.extend(['-Dnode_root_dir=%s' % node_root])
args.extend(['--depth=.']);
gyp_args = list(args)
Something went wrong with that request. Please try again.