This repository has been archived by the owner. It is now read-only.

http: Upgrade/CONNECT request should detach its socket earlier #2510

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@koichik

koichik commented Jan 11, 2012

With Upgrade or CONNECT request, http.ClientRequest emits 'close' event after its socket is closed. However, after receiving a response, the socket is not under management by the request.

http.ClientRequest should detach the socket before 'upgrade'/'connect' event is emitted to pass the socket to a user. After that, it should emit 'close' event immediately without waiting for closing of the socket.

Please review.

http: Upgrade/CONNECT request should detach its socket earlier
With Upgrade or CONNECT request, http.ClientRequest emits 'close' event
after its socket is closed. However, after receiving a response, the socket
is not under management by the request.

http.ClientRequest should detach the socket before 'upgrade'/'connect'
event is emitted to pass the socket to a user. After that, it should
emit 'close' event immediately without waiting for closing of the socket.
@bnoordhuis

This comment has been minimized.

Show comment Hide comment
@bnoordhuis

bnoordhuis Jan 11, 2012

Member

LGTM, Koichi.

Member

bnoordhuis commented Jan 11, 2012

LGTM, Koichi.

@koichik

This comment has been minimized.

Show comment Hide comment
@koichik

koichik Jan 12, 2012

Thanks Ben, merging.

koichik commented Jan 12, 2012

Thanks Ben, merging.

@koichik koichik closed this in 7dffbaf Jan 12, 2012

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.