This repository has been archived by the owner. It is now read-only.

Fix improper sample code in http.markdown #25471

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@hidekiy
Copy link

hidekiy commented Jun 2, 2015

You must consume the data from the response object. #8443
This sample code hangs up after consuming http agent's slots.

Fix improper sample code in http.markdown
You must consume the data from the response object. #8443
@jasnell

This comment has been minimized.

Copy link
Member

jasnell commented Jun 4, 2015

LGTM

jasnell added a commit that referenced this pull request Jun 5, 2015

Fix improper sample code in http.markdown
You must consume the data from the response object. #8443

Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #25471
@jasnell

This comment has been minimized.

Copy link
Member

jasnell commented Jun 5, 2015

Landed in 6671efa

@jasnell jasnell closed this Jun 5, 2015

jasnell added a commit to nodejs/node that referenced this pull request Dec 14, 2015

doc: fix improper http.get sample code
Refs: nodejs/node-v0.x-archive#25471
Refs: nodejs/node-v0.x-archive#8443
PR-URL: #4263
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

cjihrig added a commit to nodejs/node that referenced this pull request Dec 15, 2015

doc: fix improper http.get sample code
Refs: nodejs/node-v0.x-archive#25471
Refs: nodejs/node-v0.x-archive#8443
PR-URL: #4263
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit to nodejs/node that referenced this pull request Dec 30, 2015

doc: fix improper http.get sample code
Refs: nodejs/node-v0.x-archive#25471
Refs: nodejs/node-v0.x-archive#8443
PR-URL: #4263
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added a commit to nodejs/node that referenced this pull request Jan 19, 2016

doc: fix improper http.get sample code
Refs: nodejs/node-v0.x-archive#25471
Refs: nodejs/node-v0.x-archive#8443
PR-URL: #4263
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016

doc: fix improper http.get sample code
Refs: nodejs/node-v0.x-archive#25471
Refs: nodejs/node-v0.x-archive#8443
PR-URL: nodejs#4263
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.